Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 902893004: Add ButtonCompat: a Material-styled button on all versions of Android. (Closed)

Created:
5 years, 10 months ago by newt (away)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ButtonCompat: a Material-styled button on all versions of Android. This adds a new widget, ButtonCompat, which is a Material-styled button. On pre-L devices, the widget approximates the Material style, but doesn't have ripples or shadows. The color of ButtonCompat can be easily changed using setButtonColor(). This also adds a style ButtomBorderlessCompat than can be applied to Buttons to make them look like borderless Material buttons. BUG=442690 Committed: https://crrev.com/e66bc5de9f4ca9a6f3c0a46547fdaf496cbb3ce6 Cr-Commit-Position: refs/heads/master@{#314942}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : s/app/chrome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -8 lines) Patch
A chrome/android/java/res/drawable-v21/button_borderless_compat.xml View 1 chunk +10 lines, -0 lines 0 comments Download
A + chrome/android/java/res/drawable-v21/button_compat.xml View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/android/java/res/drawable/button_compat_shape.xml View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/android/java/res/values-v17/styles.xml View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/android/java/res/values-v21/styles.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/attrs.xml View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/widget/ButtonCompat.java View 1 2 1 chunk +130 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
newt (away)
PTAL
5 years, 10 months ago (2015-02-06 01:07:28 UTC) #2
aurimas (slooooooooow)
lgtm https://codereview.chromium.org/902893004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/widget/ButtonCompat.java File chrome/android/java/src/org/chromium/chrome/browser/widget/ButtonCompat.java (right): https://codereview.chromium.org/902893004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/widget/ButtonCompat.java#newcode33 chrome/android/java/src/org/chromium/chrome/browser/widget/ButtonCompat.java:33: * app:buttonColor="#f00" /> s/app/chrome
5 years, 10 months ago (2015-02-06 01:16:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902893004/40001
5 years, 10 months ago (2015-02-06 01:18:59 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-06 01:45:34 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 01:47:29 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e66bc5de9f4ca9a6f3c0a46547fdaf496cbb3ce6
Cr-Commit-Position: refs/heads/master@{#314942}

Powered by Google App Engine
This is Rietveld 408576698