chrome/android/java/res/drawable-v21/button_compat.xml - Issue 902893004: Add ButtonCompat: a Material-styled button on all versions of Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/drawable-v21/button_compat.xml

Issue 902893004: Add ButtonCompat: a Material-styled button on all versions of Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/app/chrome Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/drawable-v21/button_borderless_compat.xml ('k') | chrome/android/java/res/drawable/button_compat_shape.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/drawable-v21/button_compat.xml

diff --git a/third_party/android_data_chart/java/res/values/dimens.xml b/chrome/android/java/res/drawable-v21/button_compat.xml

similarity index 53%

copy from third_party/android_data_chart/java/res/values/dimens.xml

copy to chrome/android/java/res/drawable-v21/button_compat.xml

index 71373f96c036219d592566ec63e570b42189e97d..62992f2107c1dbc77dd2c662352d77984ca3c82a 100644

--- a/third_party/android_data_chart/java/res/values/dimens.xml

+++ b/chrome/android/java/res/drawable-v21/button_compat.xml

@@ -3,7 +3,7 @@

Use of this source code is governed by a BSD-style license that can be

found in the LICENSE file. -->

-<resources>

-

- <dimen name="data_usage_chart_height">252dp</dimen>

-</resources>

+<ripple xmlns:android="http://schemas.android.com/apk/res/android"

+ android:color="?attr/colorControlHighlight">

+ <item android:drawable="@drawable/button_compat_shape" />

+</ripple>