Do not save passwords after back-navigation

Do not save passwords after back-navigation

PasswordManager::IsSavingEnabledForCurrentPage should check, whether the last navigation was not going back in the tab history. It is unlikely that the user is submitting a password this way.

This CL ensures this by extending the PasswordManagerClient with a NavigatedThroughBackButton method.

BUG=455630
Committed: https://crrev.com/2d2cdf9973bc6cb2502d074fac08c8a51bb81926
Cr-Commit-Position: refs/heads/master@{#317563}

[vabr (Chromium), 2015-02-06 18:13:49]

vabr@chromium.org changed reviewers:
+ gcasto@chromium.org

[vabr (Chromium), 2015-02-06 18:13:49]

Hi Garrett,

How does this look to you?

Cheers,
Vaclav

[vabr (Chromium), 2015-02-10 10:00:17]

Hi Garrett,

A friendly ping. :)

Cheers,
Vaclav

On 2015/02/06 18:13:49, vabr (Chromium) wrote:
> Hi Garrett,
> 
> How does this look to you?
> 
> Cheers,
> Vaclav

[Garrett Casto, 2015-02-11 08:47:41]

I would think that the right way to go about fixing this would be to prevent
PasswordAutofillAgent from sending a PasswordFormSubmitted() message for a
navigation that was a history navigation. It looks like you just need to add a
check for PageTransitionIsNewNavigation() along with
PageTransitionIsWebTriggerable() in
PasswordAutofillAgent::LegacyDidStartProvisionalLoad().

[vabr (Chromium), 2015-02-13 15:42:20]

Thanks Garrett,
Showing it into renderer made the whole thing much simpler.

PTAL (but don't hurry, I won't be looking at it until after next week).

Cheers,
Vaclav

[Garrett Casto, 2015-02-13 17:50:56]

lgtm

[vabr (Chromium), 2015-02-23 09:52:27]

New patchsets have been uploaded after l-g-t-m from gcasto@chromium.org

[vabr (Chromium), 2015-02-23 09:53:09]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2015-02-23 09:54:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/902893003/80001

[vabr (Chromium), 2015-02-23 10:00:22]

On 2015/02/23 09:52:27, vabr (Chromium) wrote:
> New patchsets have been uploaded after l-g-t-m from mailto:gcasto@chromium.org

FYI: I uploaded https://codereview.chromium.org/902893003/#ps80001, which is
just a rebase of https://codereview.chromium.org/902893003/#ps60001 on ToT.

[commit-bot: I haz the power, 2015-02-23 10:57:22]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-23 10:57:48]

Patchset 5 (id:??) landed as
https://crrev.com/2d2cdf9973bc6cb2502d074fac08c8a51bb81926
Cr-Commit-Position: refs/heads/master@{#317563}