components/autofill/content/renderer/password_autofill_agent.cc - Issue 902893003: Do not save passwords after back-navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 902893003: Do not save passwords after back-navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Just rebased Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/renderer/password_autofill_agent.cc

diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc

index 0f642204976bdf0169fb66af846ba9bde4e36b19..fa91a4f5658d01bd7a5df09f83c5adedb3cf58ae 100644

--- a/components/autofill/content/renderer/password_autofill_agent.cc

+++ b/components/autofill/content/renderer/password_autofill_agent.cc

@@ -1082,7 +1082,9 @@ void PasswordAutofillAgent::LegacyDidStartProvisionalLoad(

navigated_frame->provisionalDataSource());

content::NavigationState* navigation_state =

document_state->navigation_state();

- if (ui::PageTransitionIsWebTriggerable(navigation_state->transition_type()) &&

+ ui::PageTransition type = navigation_state->transition_type();

+ if (ui::PageTransitionIsWebTriggerable(type) &&

+ ui::PageTransitionIsNewNavigation(type) &&

!blink::WebUserGestureIndicator::isProcessingUserGesture()) {

// If onsubmit has been called, try and save that form.

if (provisionally_saved_form_) {

« no previous file with comments | « chrome/test/data/password/dummy_submit.html ('k') | no next file » | no next file with comments »