Add chrome platform analytics to third-party.

Add chrome platform analytics to third-party.

The chrome platform analytics package enables chrome apps to connect to and send
data to Google Analytics.

BUG=457524
Committed: https://crrev.com/85339df8a81a21d954a84d48094d0fa3c89044e9
Cr-Commit-Position: refs/heads/master@{#316096}

[meacer, 2015-02-10 02:26:30]

meacer@chromium.org changed reviewers:
+ meacer@chromium.org

[meacer, 2015-02-10 02:26:30]

Security Lgtm.

[Ben Kwa, 2015-02-10 14:11:26]

kenobi@chromium.org changed reviewers:
+ cpu@chromium.org

[Ben Kwa, 2015-02-10 14:12:17]

Received LG from open-source-third-party-reviews@ in email.  See
https://groups.google.com/a/google.com/forum/#!topic/open-source-third-party-...

[Steve McKay, 2015-02-10 15:32:19]

smckay@chromium.org changed reviewers:
+ smckay@chromium.org

[Steve McKay, 2015-02-10 15:32:20]

LGTM w/ nits.

https://codereview.chromium.org/902813004/diff/1/third_party/analytics/README...
File third_party/analytics/README.chromium (right):

https://codereview.chromium.org/902813004/diff/1/third_party/analytics/README...
third_party/analytics/README.chromium:13: The compiled, bundled version of the
package is used, in order to avoid
The library is available from GitHub both as closure JS source and as a
"compiled" bundle (traditional JS). The bundle is included here so that
traditional JS apps (non-closure-compiled) can employ the library.

https://codereview.chromium.org/902813004/diff/1/third_party/analytics/README...
third_party/analytics/README.chromium:14: incurring dependencies on all of
goog.*.
s/incurring dependencies on all of goog.*./the need to closure-compile sources
that employ the library/

https://codereview.chromium.org/902813004/diff/1/third_party/analytics/README...
third_party/analytics/README.chromium:20: An externs file had to be added to
account for chrome's js model, which is
Added externs.js allowing apps that do use closure compiler to compile code
referencing this library.

[Ben Kwa, 2015-02-10 15:47:13]

New patchsets have been uploaded after l-g-t-m from
meacer@chromium.org,smckay@chromium.org

[Ben Kwa, 2015-02-10 15:48:46]

https://codereview.chromium.org/902813004/diff/1/third_party/analytics/README...
File third_party/analytics/README.chromium (right):

https://codereview.chromium.org/902813004/diff/1/third_party/analytics/README...
third_party/analytics/README.chromium:13: The compiled, bundled version of the
package is used, in order to avoid
On 2015/02/10 15:32:20, Steve McKay wrote:
> The library is available from GitHub both as closure JS source and as a
> "compiled" bundle (traditional JS). The bundle is included here so that
> traditional JS apps (non-closure-compiled) can employ the library.

Done.

https://codereview.chromium.org/902813004/diff/1/third_party/analytics/README...
third_party/analytics/README.chromium:14: incurring dependencies on all of
goog.*.
On 2015/02/10 15:32:20, Steve McKay wrote:
> s/incurring dependencies on all of goog.*./the need to closure-compile sources
> that employ the library/

This seemed redundant given the previous comment.

https://codereview.chromium.org/902813004/diff/1/third_party/analytics/README...
third_party/analytics/README.chromium:20: An externs file had to be added to
account for chrome's js model, which is
On 2015/02/10 15:32:20, Steve McKay wrote:
> Added externs.js allowing apps that do use closure compiler to compile code
> referencing this library.

Done.

[cpu_(ooo_6.6-7.5), 2015-02-11 00:33:44]

the bug seems wrong. I suggest you create a separate bug and state as clearly as
possible why we need this and there you can link to other bugs.

[chromium-reviews, 2015-02-11 00:41:53]

902813004 is just the blocking bug for the main Cloud Import feature we're
working on.

Like any app that uses Google Analytics we need a library to send
information to the GA server. This CL adds that library.

The library in question is actually developed by Google (by us in fact),
and made available to Chrome Packaged App developers via the "GoogleChrome"
GitHub org.

On Tue, Feb 10, 2015 at 4:33 PM, <cpu@chromium.org> wrote:

> the bug seems wrong. I suggest you create a separate bug and state as
> clearly as
> possible why we need this and there you can link to other bugs.
>
>
>
> https://codereview.chromium.org/902813004/
>



-- 
Steve McKay | Eng. | smckay@google.com | 310-359-8331

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ben Kwa, 2015-02-11 02:23:48]

Sorry about the confusion re: the bug.  I created a separate bug as requested. 
PTAL.

[cpu_(ooo_6.6-7.5), 2015-02-12 20:55:22]

lgtm

[Ben Kwa, 2015-02-12 20:57:38]

The CQ bit was checked by kenobi@chromium.org

[commit-bot: I haz the power, 2015-02-12 20:58:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/902813004/20001

[Dan Beam, 2015-02-12 21:00:06]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-02-12 21:00:07]

not lgtm

https://codereview.chromium.org/902813004/diff/20001/third_party/analytics/OW...
File third_party/analytics/OWNERS (right):

https://codereview.chromium.org/902813004/diff/20001/third_party/analytics/OW...
third_party/analytics/OWNERS:2: kenobi@chromium.org
this isn't useful unless you're committers

[Ben Kwa, 2015-02-12 21:03:24]

New patchsets have been uploaded after l-g-t-m from cpu@chromium.org

[Ben Kwa, 2015-02-12 21:04:21]

https://codereview.chromium.org/902813004/diff/20001/third_party/analytics/OW...
File third_party/analytics/OWNERS (right):

https://codereview.chromium.org/902813004/diff/20001/third_party/analytics/OW...
third_party/analytics/OWNERS:2: kenobi@chromium.org
On 2015/02/12 21:00:07, Dan Beam wrote:
> this isn't useful unless you're committers

Removed myself.  smckay is a committer.

[Steve McKay, 2015-02-12 21:47:51]

Still LGTM. Submit!

https://codereview.chromium.org/902813004/diff/20001/third_party/analytics/OW...
File third_party/analytics/OWNERS (right):

https://codereview.chromium.org/902813004/diff/20001/third_party/analytics/OW...
third_party/analytics/OWNERS:2: kenobi@chromium.org
On 2015/02/12 21:00:07, Dan Beam wrote:
> this isn't useful unless you're committers

Please add tbreisacher in your place.

[Dan Beam, 2015-02-12 22:33:08]

lgtm as long as licensing is cool with this and committers are in OWNERS files

[Ben Kwa, 2015-02-12 23:35:09]

New patchsets have been uploaded after l-g-t-m from
smckay@chromium.org,dbeam@chromium.org

[Ben Kwa, 2015-02-12 23:35:33]

Thanks!  Added tbreisacher@ to OWNERS in place of kenobi@.

[Ben Kwa, 2015-02-12 23:35:53]

The CQ bit was checked by kenobi@chromium.org

[commit-bot: I haz the power, 2015-02-12 23:36:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/902813004/60001

[commit-bot: I haz the power, 2015-02-13 00:15:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-13 00:16:44]

Patchset 4 (id:??) landed as
https://crrev.com/85339df8a81a21d954a84d48094d0fa3c89044e9
Cr-Commit-Position: refs/heads/master@{#316096}