third_party/analytics/README.chromium - Issue 902813004: Add chrome platform analytics to third-party.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/analytics/README.chromium

Issue 902813004: Add chrome platform analytics to third-party. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 Name: Chrome Platform Analytics

	2 URL: https://github.com/GoogleChrome/chrome-platform-analytics

	3 Version: 1.5.2

	4 Date: 2/5/2015

	5 License: Apache 2.0

	6 License File: NOT_SHIPPED

	7 Security Critical: yes

	8

	9 Description:

	10 This package supports the use of Google Analytics (GA) in Chrome Platform

	11 Applications and Extensions.

	12

	13 The compiled, bundled version of the package is used, in order to avoid
	Steve McKay 2015/02/10 15:32:20 The library is available from GitHub both as closu The library is available from GitHub both as closure JS source and as a "compiled" bundle (traditional JS). The bundle is included here so that traditional JS apps (non-closure-compiled) can employ the library. Ben Kwa 2015/02/10 15:48:46 Done. Show quoted text On 2015/02/10 15:32:20, Steve McKay wrote: > The library is available from GitHub both as closure JS source and as a > "compiled" bundle (traditional JS). The bundle is included here so that > traditional JS apps (non-closure-compiled) can employ the library. Done.
	14 incurring dependencies on all of goog.*.
	Steve McKay 2015/02/10 15:32:20 s/incurring dependencies on all of goog../the nee s/incurring dependencies on all of goog../the need to closure-compile sources that employ the library/ Ben Kwa 2015/02/10 15:48:46 This seemed redundant given the previous comment. Show quoted text On 2015/02/10 15:32:20, Steve McKay wrote: > s/incurring dependencies on all of goog.*./the need to closure-compile sources > that employ the library/ This seemed redundant given the previous comment.
	15

	16 The SHA1 hash for this version of GoogleChrome/chrome-platform-analytics is

	17 e7c6f0e6ca6edfdd6cba0cd350516e55eb513959.

	18

	19 Local Modifications:

	20 An externs file had to be added to account for chrome's js model, which is
	Steve McKay 2015/02/10 15:32:20 Added externs.js allowing apps that do use closure Added externs.js allowing apps that do use closure compiler to compile code referencing this library. Ben Kwa 2015/02/10 15:48:46 Done. Show quoted text On 2015/02/10 15:32:20, Steve McKay wrote: > Added externs.js allowing apps that do use closure compiler to compile code > referencing this library. Done.
	21 neither vanilla javascript, nor full-blown closure.

OLD	NEW

« no previous file with comments | « third_party/analytics/OWNERS ('k') | third_party/analytics/externs.js » ('j') | no next file with comments »