Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Unified Diff: content/renderer/scheduler/renderer_scheduler_impl.cc

Issue 902783003: MouseMove when the mouse is down to signal compositor priority (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/scheduler/renderer_scheduler_impl.cc
diff --git a/content/renderer/scheduler/renderer_scheduler_impl.cc b/content/renderer/scheduler/renderer_scheduler_impl.cc
index 4ffe487b3764faa5abac556b86425a6f6469ee7b..cb10808b9459e3bf4b7edb0721b213b7080f1ef2 100644
--- a/content/renderer/scheduler/renderer_scheduler_impl.cc
+++ b/content/renderer/scheduler/renderer_scheduler_impl.cc
@@ -30,6 +30,7 @@ RendererSchedulerImpl::RendererSchedulerImpl(
loading_task_runner_(
task_queue_manager_->TaskRunnerForQueue(LOADING_TASK_QUEUE)),
current_policy_(NORMAL_PRIORITY_POLICY),
+ mouse_down_(false),
policy_may_need_update_(&incoming_signals_lock_),
weak_factory_(this) {
weak_renderer_scheduler_ptr_ = weak_factory_.GetWeakPtr();
@@ -126,6 +127,16 @@ void RendererSchedulerImpl::DidReceiveInputEventOnCompositorThread(
// Ignore mouse events because on windows these can very frequent.
// Ignore keyboard events because it doesn't really make sense to enter
// compositor priority for them.
rmcilroy 2015/02/05 16:14:59 This comment needs updating (or moved and a new co
alex clarke (OOO till 29th) 2015/02/05 17:47:16 Done.
+ if (type == blink::WebInputEvent::MouseDown) {
+ mouse_down_ = true;
+ }
+ if (type == blink::WebInputEvent::MouseUp) {
+ mouse_down_ = false;
+ }
+ if (type == blink::WebInputEvent::MouseMove && mouse_down_) {
Sami 2015/02/05 15:27:28 I think you can just look at the modifiers for the
alex clarke (OOO till 29th) 2015/02/05 17:47:16 Done.
+ UpdateForInputEvent();
+ return;
+ }
if (blink::WebInputEvent::isMouseEventType(type) ||
blink::WebInputEvent::isKeyboardEventType(type)) {
return;

Powered by Google App Engine
This is Rietveld 408576698