MouseMove when the mouse is down to signal compositor priority

content/renderer/scheduler/renderer_scheduler_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/scheduler/renderer_scheduler_impl.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/trace_event/trace_event.h"
 #include "base/trace_event/trace_event_argument.h"
@@ skipping 12 matching lines @@
                                renderer_task_queue_selector_.get())),
       control_task_runner_(
           task_queue_manager_->TaskRunnerForQueue(CONTROL_TASK_QUEUE)),
       default_task_runner_(
           task_queue_manager_->TaskRunnerForQueue(DEFAULT_TASK_QUEUE)),
       compositor_task_runner_(
           task_queue_manager_->TaskRunnerForQueue(COMPOSITOR_TASK_QUEUE)),
       loading_task_runner_(
           task_queue_manager_->TaskRunnerForQueue(LOADING_TASK_QUEUE)),
       current_policy_(NORMAL_PRIORITY_POLICY),
+      mouse_down_(false),
       policy_may_need_update_(&incoming_signals_lock_),
       weak_factory_(this) {
   weak_renderer_scheduler_ptr_ = weak_factory_.GetWeakPtr();
   update_policy_closure_ = base::Bind(&RendererSchedulerImpl::UpdatePolicy,
                                       weak_renderer_scheduler_ptr_);
   end_idle_period_closure_.Reset(base::Bind(
       &RendererSchedulerImpl::EndIdlePeriod, weak_renderer_scheduler_ptr_));
   idle_task_runner_ = make_scoped_refptr(new SingleThreadIdleTaskRunner(
       task_queue_manager_->TaskRunnerForQueue(IDLE_TASK_QUEUE),
       base::Bind(&RendererSchedulerImpl::CurrentIdleTaskDeadlineCallback,
@@ skipping 75 matching lines @@
                                           estimated_next_frame_begin_ - now);
   }
 }
 
 void RendererSchedulerImpl::DidReceiveInputEventOnCompositorThread(
     blink::WebInputEvent::Type type) {
   TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"),
                "RendererSchedulerImpl::DidReceiveInputEventOnCompositorThread");
   // Ignore mouse events because on windows these can very frequent.
   // Ignore keyboard events because it doesn't really make sense to enter
   // compositor priority for them.

[rmcilroy, 2015/02/05 16:14:59]

This comment needs updating (or moved and a new comment for this new block)

[alex clarke (OOO till 29th), 2015/02/05 17:47:16]

Done.

+  if (type == blink::WebInputEvent::MouseDown) {
+    mouse_down_ = true;
+  }
+  if (type == blink::WebInputEvent::MouseUp) {
+    mouse_down_ = false;
+  }
+  if (type == blink::WebInputEvent::MouseMove && mouse_down_) {

[Sami, 2015/02/05 15:27:28]

I think you can just look at the modifiers for the MouseMove to see if any
button is down.

[alex clarke (OOO till 29th), 2015/02/05 17:47:16]

Done.

+    UpdateForInputEvent();
+    return;
+  }
   if (blink::WebInputEvent::isMouseEventType(type) ||
       blink::WebInputEvent::isKeyboardEventType(type)) {
     return;
   }
   UpdateForInputEvent();
 }
 
 void RendererSchedulerImpl::DidAnimateForInputOnCompositorThread() {
   UpdateForInputEvent();
 }
@@ skipping 205 matching lines @@
   state->SetDouble("last_input_time",
                    (last_input_time_ - base::TimeTicks()).InMillisecondsF());
   state->SetDouble(
       "estimated_next_frame_begin",
       (estimated_next_frame_begin_ - base::TimeTicks()).InMillisecondsF());
 
   return state;
 }
 
 }  // namespace content