Revert "Enable positional parameters for base::vsnprintf and base::vswprintf on Windows."

remoting/host/setup/me2me_native_messaging_host.cc

Index: remoting/host/setup/me2me_native_messaging_host.cc
diff --git a/remoting/host/setup/me2me_native_messaging_host.cc b/remoting/host/setup/me2me_native_messaging_host.cc
index 37bedac0e592b79723c13f447499bc9827e0dadf..6bc32a3e6ff9548483c60461e0494f8d2ab9a872 100644
--- a/remoting/host/setup/me2me_native_messaging_host.cc
+++ b/remoting/host/setup/me2me_native_messaging_host.cc
@@ -566,8 +566,10 @@ void Me2MeNativeMessagingHost::EnsureElevatedHostCreated() {
 
   // Create a security descriptor that gives full access to the caller and
   // denies access by anyone else.
-  std::string security_descriptor = base::StringPrintf(
-      "O:%1$sG:%1$sD:(A;;GA;;;%1$s)", base::UTF16ToASCII(user_sid).c_str());
+  std::string user_sid_utf16 = base::WideToUTF8(user_sid);

[Sergey Ulanov, 2015/02/05 20:39:12]

I think this should be user_sid_utf8

[Nico, 2015/02/05 20:41:30]

You mean _ascii, and the rhs should be UTF16ToASCII, right?

(great catch1)

[Nico, 2015/02/05 21:58:44]

Done.

+  std::string security_descriptor =
+      base::StringPrintf("O:%sG:%sD:(A;;GA;;;%s)", user_sid_utf16.c_str(),
+                         user_sid_utf16.c_str(), user_sid_utf16.c_str());
 
   ScopedSd sd = ConvertSddlToSd(security_descriptor);
   if (!sd) {