Revert "Enable positional parameters for base::vsnprintf and base::vswprintf on Windows."

remoting/host/setup/me2me_native_messaging_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/setup/me2me_native_messaging_host.h"
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 548 matching lines @@
   // presubmit: allow wstring
   std::wstring user_sid;
   if (!base::win::GetUserSidString(&user_sid)) {
     LOG(ERROR) << "Failed to query the current user SID.";
     OnError();
     return;
   }
 
   // Create a security descriptor that gives full access to the caller and
   // denies access by anyone else.
-  std::string security_descriptor = base::StringPrintf(
-      "O:%1$sG:%1$sD:(A;;GA;;;%1$s)", base::UTF16ToASCII(user_sid).c_str());
+  std::string user_sid_utf16 = base::WideToUTF8(user_sid);

[Sergey Ulanov, 2015/02/05 20:39:12]

I think this should be user_sid_utf8

[Nico, 2015/02/05 20:41:30]

You mean _ascii, and the rhs should be UTF16ToASCII, right?

(great catch1)

[Nico, 2015/02/05 21:58:44]

Done.

+  std::string security_descriptor =
+      base::StringPrintf("O:%sG:%sD:(A;;GA;;;%s)", user_sid_utf16.c_str(),
+                         user_sid_utf16.c_str(), user_sid_utf16.c_str());
 
   ScopedSd sd = ConvertSddlToSd(security_descriptor);
   if (!sd) {
     PLOG(ERROR) << "Failed to create a security descriptor for the"
                 << "Chromoting Me2Me native messaging host.";
     OnError();
     return;
   }
 
   SECURITY_ATTRIBUTES security_attributes = {0};
@@ skipping 132 matching lines @@
 
 bool Me2MeNativeMessagingHost::DelegateToElevatedHost(
     scoped_ptr<base::DictionaryValue> message) {
   NOTREACHED();
   return false;
 }
 
 #endif  // !defined(OS_WIN)
 
 }  // namespace remoting