Revert "Enable positional parameters for base::vsnprintf and base::vswprintf on Windows."

Revert "Enable positional parameters for base::vsnprintf and base::vswprintf on Windows."

This reverts r127788.  Positional parameters aren't part of the C standard
(they are part of POSIX though), we don't really use them in the codebase,
and they don't work in chrome/android with libc++.  Rather
than have a test for them, make them also not work on Windows (like they
originally didn't) -- we shouldn't use positional printf parameters anyways.

Change the 5 uses to not use positional parameters.

BUG=118064, 117028, 427718
Committed: https://crrev.com/c0107ee59bdb5b6337f7bbdb4e8210c0bfeb547b
Cr-Commit-Position: refs/heads/master@{#314963}

[Nico, 2015-02-04 17:02:31]

thakis@chromium.org changed reviewers:
+ fdegans@chromium.org, jamesr@chromium.org, jdduke@chromium.org

[Nico, 2015-02-04 17:02:31]

First to stamp wins! I think this is what we should do about this test.

[Fabrice (no longer in Chrome), 2015-02-04 17:11:21]

On 2015/02/04 17:02:31, Nico wrote:
> First to stamp wins! I think this is what we should do about this test.

LGTM, what do I win?
(Joke's on you, I'm not actually a committer)

[Nico, 2015-02-04 17:14:21]

On 2015/02/04 17:11:21, Fabrice wrote:
> On 2015/02/04 17:02:31, Nico wrote:
> > First to stamp wins! I think this is what we should do about this test.
> 
> LGTM, what do I win?
> (Joke's on you, I'm not actually a committer)

D'oh, meant to say "SECOND to stamp wins". The keys are right next to each
other.

[jdduke (slow), 2015-02-04 17:47:57]

On 2015/02/04 17:14:21, Nico wrote:
> On 2015/02/04 17:11:21, Fabrice wrote:
> > On 2015/02/04 17:02:31, Nico wrote:
> > > First to stamp wins! I think this is what we should do about this test.
> > 
> > LGTM, what do I win?
> > (Joke's on you, I'm not actually a committer)
> 
> D'oh, meant to say "SECOND to stamp wins". The keys are right next to each
> other.

lgtm, slow and steady wins the race.

[Nico, 2015-02-04 17:48:34]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-02-04 17:48:44]

On 2015/02/04 17:47:57, jdduke wrote:
> On 2015/02/04 17:14:21, Nico wrote:
> > On 2015/02/04 17:11:21, Fabrice wrote:
> > > On 2015/02/04 17:02:31, Nico wrote:
> > > > First to stamp wins! I think this is what we should do about this test.
> > > 
> > > LGTM, what do I win?
> > > (Joke's on you, I'm not actually a committer)
> > 
> > D'oh, meant to say "SECOND to stamp wins". The keys are right next to each
> > other.
> 
> lgtm, slow and steady wins the race.

Thanks! You win fdegans's commit bit.

[commit-bot: I haz the power, 2015-02-04 17:49:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/902643002/1

[commit-bot: I haz the power, 2015-02-04 19:12:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-04 19:12:04]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Nico, 2015-02-04 19:14:17]

grt, do you know why this would anger test_installer?

[grt (UTC plus 2), 2015-02-04 19:33:52]

On 2015/02/04 19:14:17, Nico wrote:
> grt, do you know why this would anger test_installer?

It looks like this change breaks the installer somehow. Try building
mini_installer and see if it works (see
http://www.chromium.org/developers/testing/windows-installer-tests for running
the test manually). I can try to help tomorrow if you can't get anywhere.

[Nico, 2015-02-04 21:30:36]

On 2015/02/04 19:33:52, grt wrote:
> On 2015/02/04 19:14:17, Nico wrote:
> > grt, do you know why this would anger test_installer?
> 
> It looks like this change breaks the installer somehow. Try building
> mini_installer and see if it works (see
> http://www.chromium.org/developers/testing/windows-installer-tests for running
> the test manually). I can try to help tomorrow if you can't get anywhere.

Thanks! Is there a way to use
http://www.chromium.org/developers/testing/windows-installer-tests with a 64-bit
build? (The binary is in out\Release_x64 in that case)

[Nico, 2015-02-04 22:00:54]

New patchsets have been uploaded after l-g-t-m from
fdegans@chromium.org,jdduke@chromium.org

[Nico, 2015-02-04 22:03:34]

thakis@chromium.org changed reviewers:
+ grt@chromium.org, sergeyu@chromium.org

[Nico, 2015-02-04 22:03:34]

grt: Please look at the installer change.
sergeyu: Please look at the remoting changes.

[grt (UTC plus 2), 2015-02-04 23:04:20]

chrome/installer lgtm.

[Nico, 2015-02-05 18:24:24]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-02-05 18:25:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/902643002/20001

[commit-bot: I haz the power, 2015-02-05 18:31:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-05 18:31:29]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2015-02-05 18:35:22]

sergeyu: ping

[Sergey Ulanov, 2015-02-05 20:39:13]

lgtm when my comment is addressed.

https://codereview.chromium.org/902643002/diff/20001/remoting/host/setup/me2m...
File remoting/host/setup/me2me_native_messaging_host.cc (right):

https://codereview.chromium.org/902643002/diff/20001/remoting/host/setup/me2m...
remoting/host/setup/me2me_native_messaging_host.cc:569: std::string
user_sid_utf16 = base::WideToUTF8(user_sid);
I think this should be user_sid_utf8

[Nico, 2015-02-05 20:41:30]

https://codereview.chromium.org/902643002/diff/20001/remoting/host/setup/me2m...
File remoting/host/setup/me2me_native_messaging_host.cc (right):

https://codereview.chromium.org/902643002/diff/20001/remoting/host/setup/me2m...
remoting/host/setup/me2me_native_messaging_host.cc:569: std::string
user_sid_utf16 = base::WideToUTF8(user_sid);
On 2015/02/05 20:39:12, Sergey Ulanov wrote:
> I think this should be user_sid_utf8

You mean _ascii, and the rhs should be UTF16ToASCII, right?

(great catch1)

[Nico, 2015-02-05 21:58:45]

https://codereview.chromium.org/902643002/diff/20001/remoting/host/setup/me2m...
File remoting/host/setup/me2me_native_messaging_host.cc (right):

https://codereview.chromium.org/902643002/diff/20001/remoting/host/setup/me2m...
remoting/host/setup/me2me_native_messaging_host.cc:569: std::string
user_sid_utf16 = base::WideToUTF8(user_sid);
On 2015/02/05 20:41:30, Nico wrote:
> On 2015/02/05 20:39:12, Sergey Ulanov wrote:
> > I think this should be user_sid_utf8
> 
> You mean _ascii, and the rhs should be UTF16ToASCII, right?
> 
> (great catch1)

Done.

[Nico, 2015-02-05 21:58:54]

New patchsets have been uploaded after l-g-t-m from
grt@chromium.org,sergeyu@chromium.org

[Nico, 2015-02-05 21:59:51]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-02-05 22:01:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/902643002/40001

[commit-bot: I haz the power, 2015-02-06 00:12:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-06 00:12:46]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Nico, 2015-02-06 00:30:55]

thakis@chromium.org changed reviewers:
+ tbarzic@chromium.org

[Nico, 2015-02-06 00:30:56]

tbarzic: Please look at the extensions/browser/api/printer_provider change

[tbarzic, 2015-02-06 00:41:04]

On 2015/02/06 00:30:56, Nico wrote:
> tbarzic: Please look at the extensions/browser/api/printer_provider change

lgtm

[Nico, 2015-02-06 00:43:16]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-02-06 00:43:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/902643002/60001

[commit-bot: I haz the power, 2015-02-06 03:42:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-06 03:45:01]

Patchset 4 (id:??) landed as
https://crrev.com/c0107ee59bdb5b6337f7bbdb4e8210c0bfeb547b
Cr-Commit-Position: refs/heads/master@{#314963}