Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: tools/cygprofile/cygprofile_unittest.cc

Issue 902633002: Fix a bunch of issues blocking 64-bit orderfile generation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove global _OBJDUMP_BINARY Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/cygprofile/cyglog_to_orderfile.py ('k') | tools/cygprofile/patch_orderfile.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/cygprofile/cygprofile_unittest.cc
diff --git a/tools/cygprofile/cygprofile_unittest.cc b/tools/cygprofile/cygprofile_unittest.cc
index 7a1a3e29090cde50e4facac371aaba77dd03e0d9..2022c03b462452f0ab2240c987ac742426f84eb6 100644
--- a/tools/cygprofile/cygprofile_unittest.cc
+++ b/tools/cygprofile/cygprofile_unittest.cc
@@ -46,12 +46,12 @@ TEST(CygprofileTest, ThreadLogBasic) {
ASSERT_EQ(2U, entries.size());
// The entries should appear in their insertion order.
const LogEntry& first_entry = entries[0];
- ASSERT_EQ(reinterpret_cast<int>(first_entry.address), 2);
+ ASSERT_EQ(reinterpret_cast<uintptr_t>(first_entry.address), 2);
ASSERT_EQ(getpid(), first_entry.pid);
ASSERT_LT(0, first_entry.tid);
const LogEntry& second_entry = entries[1];
- ASSERT_EQ(1, reinterpret_cast<int>(second_entry.address));
+ ASSERT_EQ(1, reinterpret_cast<uintptr_t>(second_entry.address));
ASSERT_EQ(first_entry.pid, second_entry.pid);
ASSERT_EQ(first_entry.tid, second_entry.tid);
@@ -87,8 +87,8 @@ TEST(CygprofileTest, ManagerBasic) {
// The flush should have moved the data to the local vector of entries.
EXPECT_EQ(2U, entries.size());
- ASSERT_EQ(2, reinterpret_cast<int>(entries[0].address));
- ASSERT_EQ(3, reinterpret_cast<int>(entries[1].address));
+ ASSERT_EQ(2, reinterpret_cast<uintptr_t>(entries[0].address));
+ ASSERT_EQ(3, reinterpret_cast<uintptr_t>(entries[1].address));
}
} // namespace
« no previous file with comments | « tools/cygprofile/cyglog_to_orderfile.py ('k') | tools/cygprofile/patch_orderfile.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698