Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/cygprofile/cyglog_to_orderfile.py

Issue 902633002: Fix a bunch of issues blocking 64-bit orderfile generation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove global _OBJDUMP_BINARY Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/cygprofile/cygprofile_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/cygprofile/cyglog_to_orderfile.py
diff --git a/tools/cygprofile/cyglog_to_orderfile.py b/tools/cygprofile/cyglog_to_orderfile.py
index 0213fa49a641a416469a5ba6a1631663932474c5..db1232809cb8f7796b478cfc5aea288003a843ab 100755
--- a/tools/cygprofile/cyglog_to_orderfile.py
+++ b/tools/cygprofile/cyglog_to_orderfile.py
@@ -220,11 +220,18 @@ def _OutputOrderfile(offsets, offset_to_symbol_infos, symbol_to_section_map,
def main():
- if len(sys.argv) != 4:
- logging.error('Usage: cyglog_to_orderfile.py <merged_cyglog> '
- '<library> <output_filename>')
+ parser = optparse.OptionParser(usage=
+ 'usage: %prog [options] <merged_cyglog> <library> <output_filename>')
+ parser.add_option('--target-arch', action='store', dest='arch',
+ default='arm',
+ choices=['arm', 'arm64', 'x86', 'x86_64', 'x64', 'mips'],
+ help='The target architecture for libchrome.so')
+ options, argv = parser.parse_args(sys.argv)
+ if len(argv) != 4:
+ parser.print_help()
return 1
- (log_filename, lib_filename, output_filename) = sys.argv[1:]
+ (log_filename, lib_filename, output_filename) = argv[1:]
+ symbol_extractor.SetArchitecture(options.arch)
obj_dir = os.path.abspath(os.path.join(
os.path.dirname(lib_filename), '../obj'))
« no previous file with comments | « no previous file | tools/cygprofile/cygprofile_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698