Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: remoting/protocol/connection_to_client.h

Issue 902613004: Fix ConnectionToClient to connect stubs only after authentication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@audio_pump
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/connection_to_client.h
diff --git a/remoting/protocol/connection_to_client.h b/remoting/protocol/connection_to_client.h
index 11f4a3404a350792ec0f401fa5ddf0d55bb79a09..9305c7c56c5b138f6d9854e6f77f6e931656a507 100644
--- a/remoting/protocol/connection_to_client.h
+++ b/remoting/protocol/connection_to_client.h
@@ -93,13 +93,10 @@ class ConnectionToClient : public base::NonThreadSafe,
virtual ClientStub* client_stub();
// Set/get the stubs which will handle messages we receive from the client.
Wez 2015/02/07 00:40:43 These methods only set, not get
Sergey Ulanov 2015/02/13 19:40:21 Done.
- // All stubs MUST be set before the session's channels become connected.
+ // These stubs must be set in EventHandler::OnConnectionAuthenticated().
Wez 2015/02/07 00:40:43 These must be called from ... ?
Sergey Ulanov 2015/02/13 19:40:21 Done.
virtual void set_clipboard_stub(ClipboardStub* clipboard_stub);
- virtual ClipboardStub* clipboard_stub();
virtual void set_host_stub(HostStub* host_stub);
- virtual HostStub* host_stub();
virtual void set_input_stub(InputStub* input_stub);
- virtual InputStub* input_stub();
// Session::EventHandler interface.
void OnSessionStateChange(Session::State state) override;
@@ -122,11 +119,6 @@ class ConnectionToClient : public base::NonThreadSafe,
// Event handler for handling events sent from this object.
EventHandler* handler_;
- // Stubs that are called for incoming messages.
- ClipboardStub* clipboard_stub_;
- HostStub* host_stub_;
- InputStub* input_stub_;
-
// The libjingle channel used to send and receive data from the remote client.
scoped_ptr<Session> session_;

Powered by Google App Engine
This is Rietveld 408576698