Fix ConnectionToClient to connect stubs only after authentication.

remoting/protocol/connection_to_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_CONNECTION_TO_CLIENT_H_
 #define REMOTING_PROTOCOL_CONNECTION_TO_CLIENT_H_
 
 #include <deque>
 #include <string>
 #include <vector>
@@ skipping 74 matching lines @@
   virtual void OnEventTimestamp(int64 timestamp);
 
   // Get the stubs used by the host to transmit messages to the client.
   // The stubs must not be accessed before OnConnectionAuthenticated(), or
   // after OnConnectionClosed().
   // Note that the audio stub will be nullptr if audio is not enabled.
   virtual VideoStub* video_stub();
   virtual AudioStub* audio_stub();
   virtual ClientStub* client_stub();
 
   // Set/get the stubs which will handle messages we receive from the client.

[Wez, 2015/02/07 00:40:43]

These methods only set, not get

[Sergey Ulanov, 2015/02/13 19:40:21]

Done.

-  // All stubs MUST be set before the session's channels become connected.
+  // These stubs must be set in EventHandler::OnConnectionAuthenticated().

[Wez, 2015/02/07 00:40:43]

These must be called from ... ?

[Sergey Ulanov, 2015/02/13 19:40:21]

Done.

   virtual void set_clipboard_stub(ClipboardStub* clipboard_stub);
-  virtual ClipboardStub* clipboard_stub();
   virtual void set_host_stub(HostStub* host_stub);
-  virtual HostStub* host_stub();
   virtual void set_input_stub(InputStub* input_stub);
-  virtual InputStub* input_stub();
 
   // Session::EventHandler interface.
   void OnSessionStateChange(Session::State state) override;
   void OnSessionRouteChange(const std::string& channel_name,
                             const TransportRoute& route) override;
 
   // ChannelDispatcherBase::EventHandler interface.
   void OnChannelInitialized(ChannelDispatcherBase* channel_dispatcher) override;
   void OnChannelError(ChannelDispatcherBase* channel_dispatcher,
                       ErrorCode error) override;
 
  private:
   void NotifyIfChannelsReady();
 
   void Close(ErrorCode error);
 
   // Stops writing in the channels.
   void CloseChannels();
 
   // Event handler for handling events sent from this object.
   EventHandler* handler_;
 
-  // Stubs that are called for incoming messages.
-  ClipboardStub* clipboard_stub_;
-  HostStub* host_stub_;
-  InputStub* input_stub_;
-
   // The libjingle channel used to send and receive data from the remote client.
   scoped_ptr<Session> session_;
 
   scoped_ptr<HostControlDispatcher> control_dispatcher_;
   scoped_ptr<HostEventDispatcher> event_dispatcher_;
   scoped_ptr<HostVideoDispatcher> video_dispatcher_;
   scoped_ptr<AudioWriter> audio_writer_;
 
   DISALLOW_COPY_AND_ASSIGN(ConnectionToClient);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_CONNECTION_TO_CLIENT_H_