Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 902503003: IndexedDB: Address performance regression with blob journals (Closed)

Created:
5 years, 5 months ago by jsbell
Modified:
5 years, 5 months ago
Reviewers:
cmumford
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Address performance regression with blob journals A fix at r313998 corrected blob accounting during transaction commits. To avoid stomping on overlapping commits, it required reading journals from the backing store, which regressed performance tests. Scope the code to only modify the journals if the transaction touches blobs. R=cmumford@chromium.org BUG=454622 Committed: https://crrev.com/05d0eec7715de17e1a9b7b9b16a5a5f37d36fb73 Cr-Commit-Position: refs/heads/master@{#315592}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M content/browser/indexed_db/indexed_db_backing_store.cc View 3 chunks +22 lines, -20 lines 0 comments Download
M content/test/data/indexeddb/corrupted_open_db_detection.html View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jsbell
cmumford@ - please take a look?
5 years, 5 months ago (2015-02-10 01:09:17 UTC) #1
cmumford
lgtm
5 years, 5 months ago (2015-02-10 18:19:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902503003/1
5 years, 5 months ago (2015-02-10 18:21:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-02-10 18:25:45 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-02-10 18:26:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05d0eec7715de17e1a9b7b9b16a5a5f37d36fb73
Cr-Commit-Position: refs/heads/master@{#315592}

Powered by Google App Engine
This is Rietveld 408576698