IndexedDB: Address performance regression with blob journals

content/browser/indexed_db/indexed_db_backing_store.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_backing_store.h"
 
 #include <algorithm>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
@@ skipping 4113 matching lines @@
 
 leveldb::Status IndexedDBBackingStore::Transaction::CommitPhaseTwo() {
   IDB_TRACE("IndexedDBBackingStore::Transaction::CommitPhaseTwo");
   leveldb::Status s;
 
   DCHECK(committing_);
   committing_ = false;
   DCHECK_GT(backing_store_->committing_transaction_count_, 0UL);
   --backing_store_->committing_transaction_count_;
 
-  // Read the persisted states of the primary/live blob journals,
-  // so that they can be updated correctly by the transaction.
-  BlobJournalType primary_journal, live_journal;
-  {
+  BlobJournalType primary_journal, live_journal, saved_primary_journal,
+      dead_blobs;
+  if (!blob_change_map_.empty()) {
+    // Read the persisted states of the primary/live blob journals,
+    // so that they can be updated correctly by the transaction.
     scoped_refptr<LevelDBTransaction> journal_transaction =
         IndexedDBClassFactory::Get()->CreateLevelDBTransaction(
             backing_store_->db_.get());
     s = GetPrimaryBlobJournal(journal_transaction.get(), &primary_journal);
     if (!s.ok())
       return s;
     s = GetLiveBlobJournal(journal_transaction.get(), &live_journal);
     if (!s.ok())
       return s;
-  }
 
-  // Remove newly added blobs from the journal - they will be accounted
-  // for in blob entry tables in the transaction.
-  {
+    // Remove newly added blobs from the journal - they will be accounted
+    // for in blob entry tables in the transaction.
     std::sort(primary_journal.begin(), primary_journal.end());
     std::sort(blobs_to_write_.begin(), blobs_to_write_.end());
     BlobJournalType new_journal = base::STLSetDifference<BlobJournalType>(
         primary_journal, blobs_to_write_);
     primary_journal.swap(new_journal);
+
+    // Append newly deleted blobs to appropriate primary/live journals.
+    saved_primary_journal = primary_journal;
+    BlobJournalType live_blobs;
+    if (!blobs_to_remove_.empty()) {
+      DCHECK(!backing_store_->is_incognito());
+      PartitionBlobsToRemove(&dead_blobs, &live_blobs);
+    }
+    primary_journal.insert(primary_journal.end(), dead_blobs.begin(),
+                           dead_blobs.end());
+    live_journal.insert(live_journal.end(), live_blobs.begin(),
+                        live_blobs.end());
+    UpdatePrimaryBlobJournal(transaction_.get(), primary_journal);
+    UpdateLiveBlobJournal(transaction_.get(), live_journal);
   }
 
-  // Append newly deleted blobs to appropriate primary/live journals.
-  BlobJournalType saved_primary_journal = primary_journal;
-  BlobJournalType dead_blobs, live_blobs;
-  if (!blobs_to_remove_.empty()) {
-    DCHECK(!backing_store_->is_incognito());
-    PartitionBlobsToRemove(&dead_blobs, &live_blobs);
-  }
-  primary_journal.insert(primary_journal.end(), dead_blobs.begin(),
-                         dead_blobs.end());
-  live_journal.insert(live_journal.end(), live_blobs.begin(), live_blobs.end());
-  UpdatePrimaryBlobJournal(transaction_.get(), primary_journal);
-  UpdateLiveBlobJournal(transaction_.get(), live_journal);
-
   // Actually commit. If this succeeds, the journals will appropriately
   // reflect pending blob work - dead files that should be deleted
   // immediately, and live files to monitor.
   s = transaction_->Commit();
   transaction_ = NULL;
 
   if (!s.ok()) {
     INTERNAL_WRITE_ERROR(TRANSACTION_COMMIT_METHOD);
     return s;
   }
@@ skipping 14 matching lines @@
       }
     }
     return leveldb::Status::OK();
   }
 
   // Actually delete dead blob files, then remove those entries
   // from the persisted primary journal.
   if (dead_blobs.empty())
     return leveldb::Status::OK();
 
+  DCHECK(!blob_change_map_.empty());
+
   s = backing_store_->CleanUpBlobJournalEntries(dead_blobs);
   if (!s.ok()) {
     INTERNAL_WRITE_ERROR_UNTESTED(TRANSACTION_COMMIT_METHOD);
     return s;
   }
 
   scoped_refptr<LevelDBTransaction> update_journal_transaction =
       IndexedDBClassFactory::Get()->CreateLevelDBTransaction(
           backing_store_->db_.get());
   UpdatePrimaryBlobJournal(update_journal_transaction.get(),
@@ skipping 178 matching lines @@
     int64_t size,
     base::Time last_modified)
     : is_file_(true),
       file_path_(file_path),
       key_(key),
       size_(size),
       last_modified_(last_modified) {
 }
 
 }  // namespace content