Issue 90243003: Use V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID() in V8Window::openMethodCustom()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 90243003: Use V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID() in V8Window::openMethodCustom() (Closed)

Created:
7 years ago by Inactive

Modified:
7 years ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID() in V8Window::openMethodCustom() Use V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID() in V8Window::openMethodCustom() to that we properly abort (return early) if v8::String::ToString() returns throws an exception. R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162765

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -13 lines)			Patch
A	LayoutTests/fast/dom/Window/open-invalid-arguments.html	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/Window/open-invalid-arguments-expected.txt	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	Source/bindings/v8/V8Binding.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	Source/bindings/v8/custom/V8WindowCustom.cpp	View	1 chunk	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/90243003/1

7 years ago (2013-11-27 01:59:41 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=18820

7 years ago (2013-11-27 04:38:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/90243003/1

7 years ago (2013-11-27 14:07:35 UTC) #5

Message was sent while issue was closed.

Change committed as 162765

Expand Messages | Collapse Messages