Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: Source/bindings/v8/V8Binding.h

Issue 90243003: Use V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID() in V8Window::openMethodCustom() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8Binding.h
diff --git a/Source/bindings/v8/V8Binding.h b/Source/bindings/v8/V8Binding.h
index 89c8edd1e67578935dd822f311550436c184f2e4..ac3a69c83184afe3d7287353a75694e72b85a589 100644
--- a/Source/bindings/v8/V8Binding.h
+++ b/Source/bindings/v8/V8Binding.h
@@ -223,15 +223,6 @@ namespace WebCore {
return stringResource;
}
- // FIXME: See the above comment.
- inline AtomicString toWebCoreAtomicString(v8::Handle<v8::Value> value)
- {
- V8StringResource<> stringResource(value);
- if (!stringResource.prepare())
- return AtomicString();
- return stringResource;
- }
-
// Convert a string to a V8 string.
// Return a V8 external string that shares the underlying buffer with the given
// WebCore string. The reference counting mechanism is used to keep the
« no previous file with comments | « LayoutTests/fast/dom/Window/open-invalid-arguments-expected.txt ('k') | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698