Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9023004: Revert 115515 - [Aura] Implement views-based applist. (Closed)

Created:
9 years ago by pastarmovj
Modified:
9 years ago
Reviewers:
xiyuan
CC:
chromium-reviews, jstritar+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, mihaip+watch_chromium.org, dcheng, Aaron Boodman, Paweł Hajdan Jr., stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 115515 - [Aura] Implement views-based applist. Implement a views-based applist behind "aura-views-applist" flag. BUG=98308, 105913 TEST=Views-based app list should have no lag. Review URL: http://codereview.chromium.org/8890049 TBR=xiyuan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2912 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
A + chrome/browser/chromeos/drop_shadow_label.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/drop_shadow_label.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/app_list_model_builder.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/app_list_model_builder.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/app_list_model_builder_unittest.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/app_list_view_delegate.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/app_list_view_delegate.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/browser_command_item.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/browser_command_item.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/chrome_app_list_item.h View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/extension_app_item.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/ui/views/aura/app_list/extension_app_item.cc View 1 chunk +0 lines, -181 lines 0 comments Download
M chrome/browser/ui/views/aura/chrome_shell_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/aura/chrome_shell_delegate.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/app_list/Extensions/dceacbkfkmllgmjmbhgkpjegnodmildf/1.0/manifest.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/app_list/Extensions/ddljohincgifmhhihcegmecmeohlfngm/1.0/manifest.json View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/app_list/Extensions/emfkafnhnpcmabnnkckkchdilgeoekbo/1.0/main.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/app_list/Extensions/emfkafnhnpcmabnnkckkchdilgeoekbo/1.0/manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/extensions/app_list/Extensions/jlklkagmeajbjiobondfhiekepofmljl/1.0/main.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/app_list/Extensions/jlklkagmeajbjiobondfhiekepofmljl/1.0/manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/extensions/app_list/Preferences View 1 chunk +0 lines, -72 lines 0 comments Download
A + ui/aura_shell/app_list.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/aura_shell/app_list.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D ui/aura_shell/app_list/app_list.h View 1 chunk +0 lines, -83 lines 0 comments Download
D ui/aura_shell/app_list/app_list.cc View 1 chunk +0 lines, -195 lines 0 comments Download
D ui/aura_shell/app_list/app_list_groups_view.h View 1 chunk +0 lines, -84 lines 0 comments Download
D ui/aura_shell/app_list/app_list_groups_view.cc View 1 chunk +0 lines, -243 lines 0 comments Download
D ui/aura_shell/app_list/app_list_item_group_model.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/aura_shell/app_list/app_list_item_group_model.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/aura_shell/app_list/app_list_item_group_view.h View 1 chunk +0 lines, -65 lines 0 comments Download
D ui/aura_shell/app_list/app_list_item_group_view.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D ui/aura_shell/app_list/app_list_item_model.h View 1 chunk +0 lines, -54 lines 0 comments Download
D ui/aura_shell/app_list/app_list_item_model.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D ui/aura_shell/app_list/app_list_item_model_observer.h View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/aura_shell/app_list/app_list_item_view.h View 1 chunk +0 lines, -72 lines 0 comments Download
D ui/aura_shell/app_list/app_list_item_view.cc View 1 chunk +0 lines, -162 lines 0 comments Download
D ui/aura_shell/app_list/app_list_item_view_listener.h View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/aura_shell/app_list/app_list_model.h View 1 chunk +0 lines, -41 lines 0 comments Download
D ui/aura_shell/app_list/app_list_model.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/aura_shell/app_list/app_list_view.h View 1 chunk +0 lines, -61 lines 0 comments Download
D ui/aura_shell/app_list/app_list_view.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D ui/aura_shell/app_list/app_list_view_delegate.h View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/aura_shell/app_list/drop_shadow_label.h View 1 chunk +0 lines, -54 lines 0 comments Download
D ui/aura_shell/app_list/drop_shadow_label.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M ui/aura_shell/aura_shell.gyp View 2 chunks +2 lines, -22 lines 0 comments Download
M ui/aura_shell/aura_shell_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura_shell/aura_shell_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/aura_shell/examples/app_list.cc View 1 chunk +0 lines, -163 lines 0 comments Download
M ui/aura_shell/examples/aura_shell_main.cc View 3 chunks +29 lines, -14 lines 0 comments Download
M ui/aura_shell/examples/example_factory.h View 2 chunks +0 lines, -13 lines 0 comments Download
M ui/aura_shell/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura_shell/shell_delegate.h View 2 chunks +0 lines, -11 lines 0 comments Download
M ui/aura_shell/test/test_shell_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura_shell/test/test_shell_delegate.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D ui/base/models/list_model.h View 1 chunk +0 lines, -116 lines 0 comments Download
D ui/base/models/list_model_observer.h View 1 chunk +0 lines, -31 lines 0 comments Download
D ui/base/models/list_model_unittest.cc View 1 chunk +0 lines, -149 lines 0 comments Download
M ui/ui.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ui_unittests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pastarmovj
9 years ago (2011-12-22 13:04:48 UTC) #1
xiyuan
Can I get more info of why r115515 is reverted? Build bots look green before ...
9 years ago (2011-12-22 16:55:39 UTC) #2
xiyuan
9 years ago (2011-12-22 17:41:53 UTC) #3 
On 2011/12/22 16:55:39, xiyuan wrote:
> Can I get more info of why r115515 is reverted?
> Build bots look green before this revert and I could not figure out what the
> failure is. Please point me to where to check. Thanks.

Never mind. Found the log:
http://build.chromium.org/p/chromium/builders/Win%20Builder%20%28dbg%29%28sha...

Powered by Google App Engine
This is Rietveld 408576698