Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 902253003: Qualify drive label selector to drive tree...return the drive icon to the Cloud Import drop down. (Closed)

Created:
5 years, 10 months ago by Steve McKay
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A small grab bag of changes relating to cloud-import icons/details panel: 1) Qualify drive label selector in test_util.js to just elements under the drive tree. And (re-)add the drive icon to the Cloud Import drop down. 2) Don't auto-hide cloud-import buttons when disabled...(fyi, they're disabled when in scanning and importing modes...we want the user to see them). 3) Format values on details panel in a human friendly way. BUG=420680 TEST=browser_test: *FileManager* Committed: https://crrev.com/fe2e3e76fe7842c9cdcf5c3aaa62081a564c42a2 Cr-Commit-Position: refs/heads/master@{#315309}

Patch Set 1 #

Patch Set 2 : Don't auto-hide cloud-import buttons when disabled. #

Patch Set 3 : Format numbers and bytes in human friendly ways. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M ui/file_manager/file_manager/background/js/test_util.js View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/import_controller.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Steve McKay
Don't auto-hide cloud-import buttons when disabled.
5 years, 10 months ago (2015-02-06 23:26:46 UTC) #1
Steve McKay
Format numbers and bytes in human friendly ways.
5 years, 10 months ago (2015-02-07 00:13:17 UTC) #3
fukino
lgtm. Thanks!
5 years, 10 months ago (2015-02-09 04:31:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902253003/40001
5 years, 10 months ago (2015-02-09 15:25:42 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-09 15:59:02 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 15:59:26 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe2e3e76fe7842c9cdcf5c3aaa62081a564c42a2
Cr-Commit-Position: refs/heads/master@{#315309}

Powered by Google App Engine
This is Rietveld 408576698