ui/file_manager/file_manager/foreground/js/import_controller.js - Issue 902253003: Qualify drive label selector to drive tree...return the drive icon to the Cloud Import drop down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/import_controller.js

Issue 902253003: Qualify drive label selector to drive tree...return the drive icon to the Cloud Import drop down. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Format numbers and bytes in human friendly ways. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/file_manager/file_manager/foreground/js/import_controller.js

diff --git a/ui/file_manager/file_manager/foreground/js/import_controller.js b/ui/file_manager/file_manager/foreground/js/import_controller.js

index a31f0072c5d7fa7af02817f8e90a1b96a55366e5..f28a901630c26cba34a23934987c5da4471fb27a 100644

--- a/ui/file_manager/file_manager/foreground/js/import_controller.js

+++ b/ui/file_manager/file_manager/foreground/js/import_controller.js

@@ -297,7 +297,7 @@ importer.ImportController.prototype.updateUi_ =

executable: false,

label: strf(

'CLOUD_IMPORT_INSUFFICIENT_SPACE_BUTTON_LABEL',

- opt_scan.getTotalBytes()),

+ util.bytesToString(opt_scan.getTotalBytes())),

coreIcon: 'report-problem'

});

this.commandWidget_.updateDetails(opt_scan);

@@ -657,8 +657,8 @@ importer.RuntimeCommandWidget.prototype.update = function(update) {

/** @override */

importer.RuntimeCommandWidget.prototype.updateDetails = function(scan) {

- this.photoCount_.textContent = scan.getFileEntries().length;

- this.spaceRequired_.textContent = scan.getTotalBytes();

+ this.photoCount_.textContent = scan.getFileEntries().length.toLocaleString();

+ this.spaceRequired_.textContent = util.bytesToString(scan.getTotalBytes());

};

/** @override */

« no previous file with comments | « ui/file_manager/file_manager/foreground/css/file_manager.css ('k') | ui/file_manager/file_manager/main.html » ('j') | no next file with comments »