Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 902133002: Pointing AppRTC browser test to new location. (Closed)

Created:
5 years, 10 months ago by phoglund_chromium
Modified:
5 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pointing AppRTC browser test to new location. Depends on https://codereview.chromium.org/907433002/. BUG=455758 TESTED=Removed the webrtc-samples directory, applied https://codereview.chromium.org/900403002, compiled and then ran: out/Release/browser_tests --run-manual --gtest_filter=WebRtcApprtcBrowserTest.MANUAL_WorksOnApprtc on Linux. Committed: https://crrev.com/c3d07759b2109408c059d55a8e52c41dfb5eaf56 Cr-Commit-Position: refs/heads/master@{#315015}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed webrtc.DEPS path. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 1 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
phoglund_chromium
5 years, 10 months ago (2015-02-06 09:41:32 UTC) #2
kjellander_chromium
I pasted my TESTED line in this CL. If you've done that and it passes, ...
5 years, 10 months ago (2015-02-06 09:47:17 UTC) #3
kjellander_chromium
found another improvement. https://codereview.chromium.org/902133002/diff/1/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc File chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc (right): https://codereview.chromium.org/902133002/diff/1/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc#newcode30 chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc:30: " \"url\" : \"svn://svn.chromium.org/chrome/trunk/deps/" Let's make ...
5 years, 10 months ago (2015-02-06 09:48:57 UTC) #4
phoglund_chromium
PTAL https://codereview.chromium.org/902133002/diff/1/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc File chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc (right): https://codereview.chromium.org/902133002/diff/1/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc#newcode30 chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc:30: " \"url\" : \"svn://svn.chromium.org/chrome/trunk/deps/" On 2015/02/06 09:48:57, kjellander ...
5 years, 10 months ago (2015-02-06 10:04:22 UTC) #6
kjellander_chromium
lgtm
5 years, 10 months ago (2015-02-06 10:06:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902133002/20001
5 years, 10 months ago (2015-02-06 12:05:49 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 12:47:33 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 12:48:38 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c3d07759b2109408c059d55a8e52c41dfb5eaf56
Cr-Commit-Position: refs/heads/master@{#315015}

Powered by Google App Engine
This is Rietveld 408576698