Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 900403002: Add new mirror for AppRTC due to code move at GitHub. (Closed)

Created:
5 years, 10 months ago by kjellander_chromium
Modified:
5 years, 10 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add new mirror for AppRTC due to code move at GitHub. This mirror will be replaced by a Chrome infra mirror as soon as crbug.com/455758 is fixed. BUG=455758 TESTED=Successfully ran gclient runhooks in a checkout with the webrtc.DEPS solution added and the old webrtc-samples dir removed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293976

Patch Set 1 #

Patch Set 2 : Specifying Git URL, renamed script and use grunt build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -101 lines) Patch
A .gitignore View 1 chunk +6 lines, -0 lines 0 comments Download
M DEPS View 1 2 chunks +6 lines, -4 lines 0 comments Download
A + build_apprtc_appengine_app.py View 1 3 chunks +8 lines, -9 lines 0 comments Download
M build_apprtc_closure.py View 1 1 chunk +0 lines, -63 lines 0 comments Download
M build_apprtc_collider.py View 1 chunk +2 lines, -2 lines 0 comments Download
M copy_apprtc.py View 2 chunks +7 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_chromium
5 years, 10 months ago (2015-02-06 08:01:41 UTC) #2
kjellander_chromium
PTAL at PS#2 after offline discussion.
5 years, 10 months ago (2015-02-06 09:47:11 UTC) #3
phoglund_chromium
lgtm
5 years, 10 months ago (2015-02-06 09:50:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900403002/20001
5 years, 10 months ago (2015-02-06 11:46:16 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 11:46:44 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293976

Powered by Google App Engine
This is Rietveld 408576698