Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 902093003: [android-webview] Enable breakpad microdump crash reporting (Closed)

Created:
5 years, 10 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
Mark Mentovai, Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@crash_refactor_for_webview
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android-webview] Enable breakpad microdump crash reporting This CL: - Pulls in the dependencies required to build breakpad and the crash component. - Introduces a crash reporter for WebView which unconditionally enables microdumps (but not minidump uploads). - Introduces a fallback no-op implementation which avoids the burden of importing and supporting breakpad in the internal Android builds (which are going to be deprecated soon). Impact of this change on the WebView APK size: Before the change: 25700337 bytes After the change: 25720974 bytes Delta: 20637 bytes Impact of this change on the uncompressed libwebviewchromium.so lib: Before the change: 28547980 bytes After the change: 28576844 bytes Delta: 28864 bytes BUG=410294, 456494 TBR=mark@chromium.org Committed: https://crrev.com/2d3f4b2a13d7a9cf0dc2a3cffed9b29f441858eb Cr-Commit-Position: refs/heads/master@{#315357}

Patch Set 1 : #

Patch Set 2 : rename + clang-format #

Patch Set 3 : Fix aw_microdump_crash_reporter_disabled_in_android_builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -0 lines) Patch
M android_webview/android_webview.gyp View 1 2 chunks +18 lines, -0 lines 0 comments Download
A android_webview/crash_reporter/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A android_webview/crash_reporter/aw_microdump_crash_reporter.h View 1 1 chunk +16 lines, -0 lines 0 comments Download
A android_webview/crash_reporter/aw_microdump_crash_reporter.cc View 1 1 chunk +54 lines, -0 lines 0 comments Download
A android_webview/crash_reporter/aw_microdump_crash_reporter_disabled_in_android_builds.cc View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Primiano Tucci (use gerrit)
PTAL. This might need some offline discussion. Not sure whether the noop-on-android-build strategy is acceptable, ...
5 years, 10 months ago (2015-02-07 14:55:20 UTC) #4
Torne
LGTM - if we need to enable it downstream we can do that later.
5 years, 10 months ago (2015-02-09 10:14:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902093003/80001
5 years, 10 months ago (2015-02-09 17:32:06 UTC) #8
Primiano Tucci (use gerrit)
TBR-ing mark@ for adding the dependency to crash/ in android_webview
5 years, 10 months ago (2015-02-09 17:36:42 UTC) #9
Primiano Tucci (use gerrit)
TBR-ing mark@ for adding the dependency to crash/ in android_webview
5 years, 10 months ago (2015-02-09 17:37:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/56394)
5 years, 10 months ago (2015-02-09 18:10:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902093003/100001
5 years, 10 months ago (2015-02-09 18:20:03 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:100001)
5 years, 10 months ago (2015-02-09 19:00:03 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 19:01:10 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2d3f4b2a13d7a9cf0dc2a3cffed9b29f441858eb
Cr-Commit-Position: refs/heads/master@{#315357}

Powered by Google App Engine
This is Rietveld 408576698