Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: android_webview/android_webview.gyp

Issue 902093003: [android-webview] Enable breakpad microdump crash reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@crash_refactor_for_webview
Patch Set: Fix aw_microdump_crash_reporter_disabled_in_android_builds Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/crash_reporter/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/android_webview.gyp
diff --git a/android_webview/android_webview.gyp b/android_webview/android_webview.gyp
index 10f98b83c9c339628588429b7a441632b96ac5b7..753a22041ee84acbda5f76deee6e4da824b554e3 100644
--- a/android_webview/android_webview.gyp
+++ b/android_webview/android_webview.gyp
@@ -259,6 +259,7 @@
'common/render_view_messages.h',
'common/url_constants.cc',
'common/url_constants.h',
+ 'crash_reporter/aw_microdump_crash_reporter.h',
'lib/aw_browser_dependency_factory_impl.cc',
'lib/aw_browser_dependency_factory_impl.h',
'lib/main/aw_main_delegate.cc',
@@ -283,6 +284,23 @@
'renderer/print_render_frame_observer.cc',
'renderer/print_render_frame_observer.h',
],
+ # TODO(primiano): remove the *_disabled_in_android_builds fallback and
+ # merge this with the target once android_webview_build goes away.
+ 'conditions': [
+ ['android_webview_build==0', {
+ 'dependencies': [
+ '../components/components.gyp:breakpad_host',
+ '../components/components.gyp:crash_component',
+ ],
+ 'sources': [
+ 'crash_reporter/aw_microdump_crash_reporter.cc',
+ ],
+ }, { # android_webview_build==1
+ 'sources': [
+ 'crash_reporter/aw_microdump_crash_reporter_disabled_in_android_builds.cc',
+ ],
+ }],
+ ],
},
{
'target_name': 'libwebviewchromium',
« no previous file with comments | « no previous file | android_webview/crash_reporter/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698