Add basic compilation support for modules

Add basic compilation support for modules

This adds an "experimental" API hook (v8::ScriptCompiler::CompileModule)
allowing compilation of modules. The code gen is incredibly basic: the
module body is represented by a Block in the AST. But this at least gets
more of the pipeline working, and opens the door to writing mjsunit tests
(once d8 is modified to support module compilation).

BUG=v8:1569
LOG=n

Committed: https://crrev.com/70079dab1386d1b5ffc80d05591597d015aeffde
Cr-Commit-Position: refs/heads/master@{#26496}

[adamk, 2015-02-06 00:40:26]

adamk@chromium.org changed reviewers:
+ rossberg@chromium.org

[rossberg, 2015-02-06 12:36:56]

lgtm

https://codereview.chromium.org/902093002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/902093002/diff/1/src/compiler.cc#newcode1138
src/compiler.cc:1138: DCHECK(info->is_eval() || info->is_global() ||
info->is_module());
Yeah, this is starting to get me worried. Module code is not "toplevel", so I'm
wondering what assumptions might break with this. At some point we'll probably
have to rethink/refactor this.

https://codereview.chromium.org/902093002/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):

https://codereview.chromium.org/902093002/diff/1/src/full-codegen.cc#newcode730
src/full-codegen.cc:730: //  DeclareModules(modules_);
Is this stray? Or a TODO?

[adamk, 2015-02-06 17:29:00]

New patchsets have been uploaded after l-g-t-m from rossberg@chromium.org

[adamk, 2015-02-06 17:29:08]

https://codereview.chromium.org/902093002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/902093002/diff/1/src/compiler.cc#newcode1138
src/compiler.cc:1138: DCHECK(info->is_eval() || info->is_global() ||
info->is_module());
On 2015/02/06 12:36:56, rossberg wrote:
> Yeah, this is starting to get me worried. Module code is not "toplevel", so
I'm
> wondering what assumptions might break with this. At some point we'll probably
> have to rethink/refactor this.

I wouldn't be too worried, yet anyway. This is why I wanted to get the compiler
working, so I can get some more tests in and then refactor as need-be. In the
mid-term run, I think we probably do want to make module compilation more
separate from toplevel compilation. But doing that right now would lead either
to too much code duplication or too much brokenness.

If you have concrete suggestions for refactoring that could happen earlier,
please let me know.

https://codereview.chromium.org/902093002/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):

https://codereview.chromium.org/902093002/diff/1/src/full-codegen.cc#newcode730
src/full-codegen.cc:730: //  DeclareModules(modules_);
On 2015/02/06 12:36:56, rossberg wrote:
> Is this stray? Or a TODO?

Oops. This is a TODO, I thought I'd managed to fix everything but I have not
yet. Added more explanation.

[adamk, 2015-02-06 17:29:20]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2015-02-06 17:30:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/902093002/20001

[commit-bot: I haz the power, 2015-02-06 17:52:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-06 17:52:55]

Patchset 2 (id:??) landed as
https://crrev.com/70079dab1386d1b5ffc80d05591597d015aeffde
Cr-Commit-Position: refs/heads/master@{#26496}