Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 902093002: Add basic compilation support for modules (Closed)

Created:
5 years, 10 months ago by adamk
Modified:
5 years, 10 months ago
Reviewers:
rossberg
CC:
v8-dev, Paweł Hajdan Jr., arv (Not doing code reviews), dcarney
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add basic compilation support for modules This adds an "experimental" API hook (v8::ScriptCompiler::CompileModule) allowing compilation of modules. The code gen is incredibly basic: the module body is represented by a Block in the AST. But this at least gets more of the pipeline working, and opens the door to writing mjsunit tests (once d8 is modified to support module compilation). BUG=v8:1569 LOG=n Committed: https://crrev.com/70079dab1386d1b5ffc80d05591597d015aeffde Cr-Commit-Position: refs/heads/master@{#26496}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -122 lines) Patch
M include/v8.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/api.cc View 4 chunks +27 lines, -6 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 1 1 chunk +7 lines, -2 lines 0 comments Download
M src/parser.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/parser.cc View 7 chunks +11 lines, -39 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/cctest/test-modules.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 10 chunks +50 lines, -64 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
adamk
5 years, 10 months ago (2015-02-06 00:40:27 UTC) #2
rossberg
lgtm https://codereview.chromium.org/902093002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/902093002/diff/1/src/compiler.cc#newcode1138 src/compiler.cc:1138: DCHECK(info->is_eval() || info->is_global() || info->is_module()); Yeah, this is ...
5 years, 10 months ago (2015-02-06 12:36:56 UTC) #3
adamk
https://codereview.chromium.org/902093002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/902093002/diff/1/src/compiler.cc#newcode1138 src/compiler.cc:1138: DCHECK(info->is_eval() || info->is_global() || info->is_module()); On 2015/02/06 12:36:56, rossberg ...
5 years, 10 months ago (2015-02-06 17:29:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902093002/20001
5 years, 10 months ago (2015-02-06 17:30:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 17:52:28 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 17:52:55 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70079dab1386d1b5ffc80d05591597d015aeffde
Cr-Commit-Position: refs/heads/master@{#26496}

Powered by Google App Engine
This is Rietveld 408576698