Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: src/full-codegen.cc

Issue 902093002: Add basic compilation support for modules (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add TODO Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug.cc ('k') | src/parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen.cc
diff --git a/src/full-codegen.cc b/src/full-codegen.cc
index e72dc7c5fdb3f832c76440affd7545bbc0035ea2..c7025263ad83beb9c86c196cc9b14f0d36d5c471 100644
--- a/src/full-codegen.cc
+++ b/src/full-codegen.cc
@@ -725,9 +725,14 @@ void FullCodeGenerator::VisitDeclarations(
AstVisitor::VisitDeclarations(declarations);
if (scope_->num_modules() != 0) {
+ // TODO(ES6): This step, which creates module instance objects,
+ // can probably be delayed until an "import *" declaration
+ // reifies a module instance. Until imports are implemented,
+ // we skip it altogether.
+ //
// Initialize modules from descriptor array.
- DCHECK(module_index_ == modules_->length());
- DeclareModules(modules_);
+ // DCHECK(module_index_ == modules_->length());
+ // DeclareModules(modules_);
modules_ = saved_modules;
module_index_ = saved_module_index;
}
« no previous file with comments | « src/debug.cc ('k') | src/parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698