Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 902053005: X87: Introduce LanguageMode, drop StrictMode. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Introduce LanguageMode, drop StrictMode. port c7851da4aefb644ab198ead1fa284932fd424797 (r26419) original commit message: Introduce LanguageMode, drop StrictMode. This enables adding more language modes in the future. For maximum flexibility, LanguageMode is a bitmask, so we're not restricted to use a sequence of language modes which are progressively stricter, but we can express the language mode as combination of features. For now, LanguageMode can only be "sloppy" or "strict", and there are STATIC_ASSERTS in places which need to change when more modes are added. LanguageMode is a bit like the old LanguageMode when "extended" mode was still around (see https://codereview.chromium.org/8417035 and https://codereview.chromium.org/181543002 ) except that it's transmitted through all the layers (there's no StrictModeFlag). BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/4ee51619620ae86a27fc5ad7c3d24240ed880303

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -30 lines) Patch
M src/ic/x87/ic-compiler-x87.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 13 chunks +19 lines, -17 lines 0 comments Download
M src/x87/lithium-codegen-x87.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/lithium-codegen-x87.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M src/x87/lithium-x87.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-09 08:42:40 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-09 08:48:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902053005/1
5 years, 10 months ago (2015-02-09 08:48:29 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4ee51619620ae86a27fc5ad7c3d24240ed880303 Cr-Commit-Position: refs/heads/master@{#26514}
5 years, 10 months ago (2015-02-09 08:50:20 UTC) #6
chunyang.dai
5 years, 10 months ago (2015-02-09 08:50:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4ee51619620ae86a27fc5ad7c3d24240ed880303 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698