Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 181543002: Eliminate extended mode, and other modes clean-up (Closed)

Created:
6 years, 10 months ago by rossberg
Modified:
6 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Eliminate extended mode, and other modes clean-up - Merge LanguageMode and StrictModeFlag enums - Make harmony-scoping depend only on strict mode - Free some bits on the way - Plus additional clean-up and renaming R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+859 lines, -1040 lines) Patch
M src/a64/code-stubs-a64.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M src/a64/full-codegen-a64.cc View 19 chunks +25 lines, -28 lines 0 comments Download
M src/a64/ic-a64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/a64/lithium-a64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/a64/lithium-codegen-a64.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M src/accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 18 chunks +27 lines, -31 lines 0 comments Download
M src/arm/ic-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm/lithium-arm.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M src/ast.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ast.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/bootstrapper.cc View 14 chunks +43 lines, -41 lines 0 comments Download
M src/builtins.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/code-stubs.h View 6 chunks +9 lines, -10 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compilation-cache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compilation-cache.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/compiler.h View 4 chunks +15 lines, -21 lines 0 comments Download
M src/compiler.cc View 15 chunks +18 lines, -30 lines 0 comments Download
M src/contexts.h View 5 chunks +27 lines, -26 lines 0 comments Download
M src/contexts.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/execution.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/factory.cc View 5 chunks +9 lines, -11 lines 0 comments Download
M src/full-codegen.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/globals.h View 1 chunk +2 lines, -24 lines 0 comments Download
M src/handles.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/heap.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 15 chunks +21 lines, -23 lines 0 comments Download
M src/hydrogen-instructions.h View 10 chunks +15 lines, -15 lines 0 comments Download
M src/i18n.cc View 33 chunks +40 lines, -40 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 17 chunks +25 lines, -28 lines 0 comments Download
M src/ia32/ic-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic.h View 9 chunks +14 lines, -15 lines 0 comments Download
M src/ic.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/json-parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 20 chunks +32 lines, -54 lines 0 comments Download
M src/objects.cc View 50 chunks +65 lines, -87 lines 0 comments Download
M src/objects-inl.h View 1 chunk +7 lines, -25 lines 0 comments Download
M src/parser.h View 3 chunks +5 lines, -10 lines 0 comments Download
M src/parser.cc View 36 chunks +72 lines, -64 lines 0 comments Download
M src/preparse-data.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/preparser.h View 9 chunks +19 lines, -29 lines 0 comments Download
M src/preparser.cc View 15 chunks +26 lines, -29 lines 0 comments Download
M src/runtime.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/runtime.cc View 47 chunks +56 lines, -78 lines 0 comments Download
M src/scopeinfo.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/scopes.h View 4 chunks +9 lines, -15 lines 0 comments Download
M src/scopes.cc View 7 chunks +8 lines, -16 lines 0 comments Download
M src/stub-cache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/stub-cache.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/token.h View 1 chunk +1 line, -1 line 0 comments Download
M src/v8globals.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/variables.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 17 chunks +25 lines, -28 lines 0 comments Download
M src/x64/ic-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 12 chunks +25 lines, -26 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +55 lines, -53 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 10 months ago (2014-02-26 14:56:39 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-11 11:17:38 UTC) #2
rossberg
6 years, 9 months ago (2014-03-11 14:42:07 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r19800.

Powered by Google App Engine
This is Rietveld 408576698