Add SRT log upload result metrics.

Add SRT log upload result metrics.

BUG=NONE
TEST=NONE

Committed: https://crrev.com/f787d755375933fadb4b795bd70f9730a30e8caf
Cr-Commit-Position: refs/heads/master@{#316048}

[robertshield, 2015-02-11 21:39:25]

robertshield@chromium.org changed reviewers:
+ mad@chromium.org

[MAD, 2015-02-11 22:26:49]

LGTM, with one important fix request! :-)

Thanks!

BYE
MAD

https://codereview.chromium.org/901903005/diff/1/chrome/browser/component_upd...
File chrome/browser/component_updater/sw_reporter_installer_win.cc (right):

https://codereview.chromium.org/901903005/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/sw_reporter_installer_win.cc:395: if (false &&
Héhé... :-)

You know you can also simply enable UMA... ;-)
Or you could force the fieldtrial on the command line.

[robertshield, 2015-02-11 22:34:15]

New patchsets have been uploaded after l-g-t-m from mad@chromium.org

[robertshield, 2015-02-11 22:36:16]

Thanks MAD!

Alexei, please could you take an OWNERS look at histograms.xml

https://codereview.chromium.org/901903005/diff/1/chrome/browser/component_upd...
File chrome/browser/component_updater/sw_reporter_installer_win.cc (right):

https://codereview.chromium.org/901903005/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/sw_reporter_installer_win.cc:395: if (false &&
On 2015/02/11 22:26:49, MAD wrote:
> Héhé... :-)
> 
> You know you can also simply enable UMA... ;-)
> Or you could force the fieldtrial on the command line.

Heh, oops, shouldn't leave test code lying around like that. Thanks for
catching!

[robertshield, 2015-02-12 01:46:53]

robertshield@chromium.org changed reviewers:
+ asvitkine@chromium.org

[robertshield, 2015-02-12 01:46:53]

+Alexei for real this time

[Alexei Svitkine (slow), 2015-02-12 15:27:14]

https://codereview.chromium.org/901903005/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/901903005/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:36364: +<histogram
name="SoftwareReporter.LastUploadResult">
This seems like a boolean histogram, please add an appropriate enum="" entry.

https://codereview.chromium.org/901903005/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:36366: +  <summary>The result of the
most recent SRT log upload.</summary>
What do the different values mean?

https://codereview.chromium.org/901903005/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:36409: +  <summary>The longest run of
upload failures.</summary>
Please mention when this is logged, for all of these.

https://codereview.chromium.org/901903005/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:36415: +    The total count of
successful SRT log uploads experienced by this client.
Is this cumulative? When do the values get reset? Is it the amount in the
current session, or? Please clarify.

[robertshield, 2015-02-12 15:45:03]

Thanks, PTAL

https://codereview.chromium.org/901903005/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/901903005/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:36364: +<histogram
name="SoftwareReporter.LastUploadResult">
On 2015/02/12 15:27:14, Alexei Svitkine wrote:
> This seems like a boolean histogram, please add an appropriate enum="" entry.

Done.

https://codereview.chromium.org/901903005/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:36366: +  <summary>The result of the
most recent SRT log upload.</summary>
On 2015/02/12 15:27:14, Alexei Svitkine wrote:
> What do the different values mean?

The existing BooleanSuccess enum applies here, the convention seems to be not to
explicitly state 0 = Failure, 1 = success when that is the case so I'm not
expanding the comment. Let me know if that sg.

https://codereview.chromium.org/901903005/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:36409: +  <summary>The longest run of
upload failures.</summary>
On 2015/02/12 15:27:14, Alexei Svitkine wrote:
> Please mention when this is logged, for all of these.

Done.

https://codereview.chromium.org/901903005/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:36415: +    The total count of
successful SRT log uploads experienced by this client.
On 2015/02/12 15:27:14, Alexei Svitkine wrote:
> Is this cumulative? When do the values get reset? Is it the amount in the
> current session, or? Please clarify.

Clarification attempted. Let me know if you still have questions.

[Alexei Svitkine (slow), 2015-02-12 15:49:18]

lgtm

[robertshield, 2015-02-12 19:24:06]

robertshield@chromium.org changed reviewers:
+ waffles@chromium.org

[robertshield, 2015-02-12 19:24:06]

+waffles@ for OWNERS on the component_updater bits

[waffles, 2015-02-12 20:57:36]

waffles@chromium.org changed reviewers:
+ waffles@chromium.org

[waffles, 2015-02-12 20:57:37]

lgtm

[robertshield, 2015-02-12 21:12:38]

The CQ bit was checked by robertshield@chromium.org

[commit-bot: I haz the power, 2015-02-12 21:13:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/901903005/40001

[commit-bot: I haz the power, 2015-02-12 21:18:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-12 21:18:47]

Patchset 3 (id:??) landed as
https://crrev.com/f787d755375933fadb4b795bd70f9730a30e8caf
Cr-Commit-Position: refs/heads/master@{#316048}