tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index d4340efe0a57d65816be139d826d78b1da86aa63..8ff83e2fb5c735f1f7b57bd497c621eaab5bf334 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -36361,6 +36361,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <summary>The build version of the software reporter cleaner tool.</summary>
 </histogram>
 
+<histogram name="SoftwareReporter.LastUploadResult">

[Alexei Svitkine (slow), 2015/02/12 15:27:14]

This seems like a boolean histogram, please add an appropriate enum="" entry.

[robertshield, 2015/02/12 15:45:02]

Done.

+  <owner>mad@chromium.org</owner>
+  <summary>The result of the most recent SRT log upload.</summary>

[Alexei Svitkine (slow), 2015/02/12 15:27:14]

What do the different values mean?

[robertshield, 2015/02/12 15:45:02]

The existing BooleanSuccess enum applies here, the convention seems to be not to
explicitly state 0 = Failure, 1 = success when that is the case so I'm not
expanding the comment. Let me know if that sg.

+</histogram>
+
 <histogram name="SoftwareReporter.MajorVersion">
   <owner>mad@chromium.org</owner>
   <summary>
@@ -36392,6 +36397,25 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="SoftwareReporter.UploadFailureCount">
+  <owner>mad@chromium.org</owner>
+  <summary>
+    The total count of SRT log upload failures experienced by this client.
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.UploadLongestFailureRun">
+  <owner>mad@chromium.org</owner>
+  <summary>The longest run of upload failures.</summary>

[Alexei Svitkine (slow), 2015/02/12 15:27:14]

Please mention when this is logged, for all of these.

[robertshield, 2015/02/12 15:45:02]

Done.

+</histogram>
+
+<histogram name="SoftwareReporter.UploadSuccessCount">
+  <owner>mad@chromium.org</owner>
+  <summary>
+    The total count of successful SRT log uploads experienced by this client.

[Alexei Svitkine (slow), 2015/02/12 15:27:14]

Is this cumulative? When do the values get reset? Is it the amount in the
current session, or? Please clarify.

[robertshield, 2015/02/12 15:45:02]

Clarification attempted. Let me know if you still have questions.

+  </summary>
+</histogram>
+
 <histogram name="SpellCheck.SpellingService.Enabled" enum="BooleanEnabled">
   <owner>groby@chromium.org</owner>
   <owner>rlp@chromium.org</owner>