Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 901903002: [WIP]Issue FrameDestructionObserver::frameDestroyed() notification on detach. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[WIP]Issue FrameDestructionObserver::frameDestroyed() notification on detach.

Patch Set 1 #

Patch Set 2 : Clear DOMWindow on frame detach #

Patch Set 3 : Too strong; clear supplements map only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -57 lines) Patch
M LayoutTests/OilpanExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 4 chunks +22 lines, -22 lines 0 comments Download
M Source/core/frame/FrameDestructionObserver.h View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/frame/FrameDestructionObserver.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 2 3 chunks +13 lines, -2 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 2 3 chunks +9 lines, -10 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698