base/synchronization/waitable_event_watcher_win.cc - Issue 901773002: Adding instrumentation to locate the source of jankiness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/synchronization/waitable_event_watcher_win.cc

Issue 901773002: Adding instrumentation to locate the source of jankiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile + remove some tracking Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/synchronization/waitable_event_watcher_win.cc

diff --git a/base/synchronization/waitable_event_watcher_win.cc b/base/synchronization/waitable_event_watcher_win.cc

index f5218f1361db873f4edae934399978672a5c523b..a04a435a0d46e2d7aeaebc44e1cb3eaaa0f3465c 100644

--- a/base/synchronization/waitable_event_watcher_win.cc

+++ b/base/synchronization/waitable_event_watcher_win.cc

@@ -39,7 +39,8 @@ WaitableEvent* WaitableEventWatcher::GetWatchedEvent() {

void WaitableEventWatcher::OnObjectSignaled(HANDLE h) {

// TODO(vadimt): Remove ScopedTracker below once crbug.com/418183 is fixed.

tracked_objects::ScopedTracker tracking_profile(

- FROM_HERE_WITH_EXPLICIT_FUNCTION("WaitableEventWatche_OnObjectSignaled"));

+ FROM_HERE_WITH_EXPLICIT_FUNCTION(

+ "418183 WaitableEventWatcher::OnObjectSignaled"));

WaitableEvent* event = event_;

EventCallback callback = callback_;

« no previous file with comments | « base/process/kill_win.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('j') | no next file with comments »