Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 901723003: Cleanup //chrome/browser/history/DEPS (Closed)

Created:
5 years, 10 months ago by sdefresne
Modified:
5 years, 10 months ago
Reviewers:
droger, sky
CC:
browser-components-watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup //chrome/browser/history/DEPS Remove old exceptions that are no longer useful after the corresponding dependencies have been abstracted, removed or componentized. Remove some obsolete #include from history_service.cc instead of leaving the corresponding exception in the DEPS file since they are not used. Add a //chrome/browser/history/android/DEPS that remove the exclusions and exceptions since the remaining code there will not be componentized (at least this is not blocking the iOS componentization and upstreaming effort since this is Android specific code). BUG=370850 TBR=sky@chromium.org Committed: https://crrev.com/e1c1f401c020593c9d4fc4a4e7fd79132ae1a441 Cr-Commit-Position: refs/heads/master@{#314800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -33 lines) Patch
M chrome/browser/history/DEPS View 2 chunks +30 lines, -30 lines 0 comments Download
A chrome/browser/history/android/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/history/history_service.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sdefresne
5 years, 10 months ago (2015-02-05 10:00:37 UTC) #1
sdefresne
Please take a look.
5 years, 10 months ago (2015-02-05 10:01:02 UTC) #2
droger
lgtm
5 years, 10 months ago (2015-02-05 10:05:08 UTC) #4
sdefresne
TBR-ing sky for the new DEPS since they are just changing ! exceptions in + ...
5 years, 10 months ago (2015-02-05 10:19:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901723003/1
5 years, 10 months ago (2015-02-05 10:20:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 13:59:49 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 14:01:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1c1f401c020593c9d4fc4a4e7fd79132ae1a441
Cr-Commit-Position: refs/heads/master@{#314800}

Powered by Google App Engine
This is Rietveld 408576698