OLD | NEW |
1 include_rules = [ | 1 include_rules = [ |
2 # History is being made into a Browser Component (http://crbug.com/370850), so | 2 # History is being made into a Browser Component (http://crbug.com/370850), so |
3 # we have these basic rules followed by temporary exceptions. Please don't | 3 # we have these basic rules followed by temporary exceptions. Please don't |
4 # add to the list of exceptions! | 4 # add to the list of exceptions! |
5 # | 5 # |
6 # Please send reviews to sdefresne@chromium.org when adding dependencies to | 6 # Please send reviews to sdefresne@chromium.org when adding dependencies to |
7 # this list. | 7 # this list. |
8 "-chrome/browser", | 8 "-chrome/browser", |
9 "-components/search_engines", | 9 "-components", |
10 "+chrome/browser/chrome_notification_types.h", | 10 |
11 "+chrome/browser/common", | |
12 "+chrome/browser/favicon", | |
13 "+chrome/browser/history", | 11 "+chrome/browser/history", |
14 "+chrome/browser/network_time", | 12 "+components/history", |
15 "+chrome/tools/profiles", # For history unit tests. | 13 "+components/favicon_base", |
16 "+components/visitedlink/browser", | 14 "+components/keyed_service/core", |
| 15 "+components/signin/core/browser", |
17 | 16 |
18 # TODO(sdefresne): Bring this list to zero. | 17 # TODO(sdefresne): Bring this list to zero. |
19 # | 18 # |
20 # Do not add to the list of temporarily-allowed dependencies below, | 19 # Do not add to the list of temporarily-allowed dependencies below, |
21 # and please do not introduce more #includes of these files. | 20 # and please do not introduce more #includes of these files. |
22 "!chrome/browser/autocomplete/history_url_provider.h", | 21 "!chrome/browser/autocomplete/history_url_provider.h", |
23 "!chrome/browser/bookmarks/bookmark_model_factory.h", | 22 "!chrome/browser/chrome_notification_types.h", |
24 "!chrome/browser/bookmarks/chrome_bookmark_client.h", | |
25 "!chrome/browser/bookmarks/chrome_bookmark_client_factory.h", | |
26 "!chrome/browser/browser_process.h", | |
27 "!chrome/browser/chromeos/login/existing_user_controller.h", | |
28 "!chrome/browser/content_settings/cookie_settings.h", | |
29 "!chrome/browser/diagnostics/sqlite_diagnostics.h", | |
30 "!chrome/browser/omnibox/omnibox_field_trial.h", | |
31 "!chrome/browser/prefs/scoped_user_pref_update.h", | |
32 "!chrome/browser/prerender/prerender_contents.h", | 23 "!chrome/browser/prerender/prerender_contents.h", |
33 "!chrome/browser/prerender/prerender_manager.h", | 24 "!chrome/browser/prerender/prerender_manager.h", |
34 "!chrome/browser/prerender/prerender_manager_factory.h", | 25 "!chrome/browser/prerender/prerender_manager_factory.h", |
35 "!chrome/browser/profiles/incognito_helpers.h", | 26 "!chrome/browser/profiles/incognito_helpers.h", |
36 "!chrome/browser/profiles/profile.h", | 27 "!chrome/browser/profiles/profile.h", |
37 "!chrome/browser/profiles/profile_manager.h", | 28 "!chrome/browser/profiles/profile_manager.h", |
38 "!chrome/browser/signin/oauth2_token_service.h", | |
39 "!chrome/browser/signin/profile_oauth2_token_service.h", | |
40 "!chrome/browser/signin/profile_oauth2_token_service_factory.h", | 29 "!chrome/browser/signin/profile_oauth2_token_service_factory.h", |
41 "!chrome/browser/signin/signin_manager.h", | |
42 "!chrome/browser/signin/signin_manager_factory.h", | 30 "!chrome/browser/signin/signin_manager_factory.h", |
43 "!chrome/browser/signin/token_service_factory.h", | |
44 "!chrome/browser/sync/profile_sync_service.h", | |
45 "!chrome/browser/sync/profile_sync_service_factory.h", | |
46 "!chrome/browser/sync/profile_sync_service_mock.h", | |
47 "!chrome/browser/ui/browser.h", | 31 "!chrome/browser/ui/browser.h", |
48 "!chrome/browser/ui/browser_finder.h", | 32 "!chrome/browser/ui/browser_finder.h", |
49 "!chrome/browser/ui/profile_error_dialog.h", | |
50 "!chrome/browser/ui/webui/ntp/most_visited_handler.h", | |
51 "!chrome/browser/ui/webui/ntp/new_tab_ui.h", | |
52 "!components/bookmarks/browser/bookmark_model.h", | |
53 "!components/bookmarks/browser/bookmark_utils.h", | 33 "!components/bookmarks/browser/bookmark_utils.h", |
54 "!components/omnibox/autocomplete_match.h", | 34 "!components/dom_distiller/core/url_constants.h", |
55 "!components/omnibox/autocomplete_result.h", | 35 "!components/omnibox/omnibox_field_trial.h", |
56 "!components/omnibox/url_prefix.h", | 36 "!components/omnibox/url_prefix.h", |
| 37 "!components/visitedlink/browser/visitedlink_delegate.h", |
| 38 "!components/visitedlink/browser/visitedlink_master.h", |
57 ] | 39 ] |
58 | 40 |
59 specific_include_rules = { | 41 specific_include_rules = { |
60 # Browser tests, by definition, need access to the browser objects. | 42 # Browser tests, by definition, need access to the browser objects. |
61 '.*_(api|browser|)test\.cc': [ | 43 '.*_(api|browser|)test\.cc': [ |
62 "+chrome/browser", | 44 "+chrome/browser", |
63 ], | 45 ], |
| 46 # chrome_.* and .*_factory won't be componentized as they belong to the |
| 47 # embedder, so they can depend on other feature in chrome/. Same thing |
| 48 # for android specific code. |
| 49 '(chrome_.*|.*_factory)\.(cc|h)': [ |
| 50 "+chrome/browser/bookmarks/bookmark_model_factory.h", |
| 51 "+chrome/browser/bookmarks/chrome_bookmark_client.h", |
| 52 "+chrome/browser/bookmarks/chrome_bookmark_client_factory.h", |
| 53 "+chrome/browser/content_settings/cookie_settings.h", |
| 54 "+chrome/browser/sync/profile_sync_service.h", |
| 55 "+chrome/browser/sync/profile_sync_service_factory.h", |
| 56 "+chrome/browser/ui/profile_error_dialog.h", |
| 57 "+components/bookmarks/browser", |
| 58 "+components/keyed_service/content", |
| 59 ], |
64 # TODO(sdefresne): Bring this list to zero. | 60 # TODO(sdefresne): Bring this list to zero. |
65 # | 61 # |
66 # Do not add to the list of temporarily-allowed dependencies below, | 62 # Do not add to the list of temporarily-allowed dependencies below, |
67 # and please do not introduce more #includes of these files. | 63 # and please do not introduce more #includes of these files. |
68 '.*_[a-z]*test\.cc': [ | 64 '.*_[a-z]*test\.cc': [ |
| 65 "!chrome/browser/autocomplete/scored_history_match_builder.h", |
| 66 "!chrome/browser/bookmarks/bookmark_model_factory.h", |
| 67 "!chrome/browser/sync/profile_sync_service.h", |
| 68 "!chrome/browser/sync/profile_sync_service_factory.h", |
| 69 "!chrome/browser/sync/profile_sync_service_mock.h", |
69 "!components/bookmarks/test/bookmark_test_helpers.h", | 70 "!components/bookmarks/test/bookmark_test_helpers.h", |
70 "!components/bookmarks/test/test_bookmark_client.h", | |
71 ] | 71 ] |
72 } | 72 } |
OLD | NEW |