Make NaCl process non-dumpable.

Make NaCl process non-dumpable.

This can be disabled with the allow-sandbox-debugging flag.

BUG=455964
Committed: https://crrev.com/8dea07ad5e83f5f4c11dfb3053d58016ccc000cf
Cr-Commit-Position: refs/heads/master@{#315139}

[rickyz (no longer on Chrome), 2015-02-06 01:36:34]

rickyz@chromium.org changed reviewers:
+ jln@chromium.org, mseaborn@chromium.org

[jln (very slow on Chromium), 2015-02-06 01:40:24]

lgtm

[Mark Seaborn, 2015-02-06 21:02:06]

LGTM

https://codereview.chromium.org/901683003/diff/1/components/nacl/loader/sandb...
File components/nacl/loader/sandbox_linux/nacl_sandbox_linux.cc (right):

https://codereview.chromium.org/901683003/diff/1/components/nacl/loader/sandb...
components/nacl/loader/sandbox_linux/nacl_sandbox_linux.cc:62: if
(prctl(PR_SET_DUMPABLE, 0) != 0) {
This might not work after https://codereview.chromium.org/888903004/ lands, so
it would be best to check to avoid a collision.

I think it would be necessary to use "prctl(PR_SET_DUMPABLE, 0, 0, 0, 0)",
because native_client/src/public/linux_syscalls/sys/prctl.h declares:

int prctl(int option, uintptr_t arg2, uintptr_t arg3,
          uintptr_t arg4, uintptr_t arg5);

(As does linux_syscall_support.h.  It's a pedantic way to avoid varargs-based
undefined behaviour.)

[rickyz (no longer on Chrome), 2015-02-06 22:35:16]

New patchsets have been uploaded after l-g-t-m from
jln@chromium.org,mseaborn@chromium.org

[rickyz (no longer on Chrome), 2015-02-06 22:37:59]

Adding nasko@ for content/public/common/content_switches.h (sorry for spamming
you with so many of these lately)

(Sorry, accidentally included a rebase in that last upload.)

[rickyz (no longer on Chrome), 2015-02-06 22:38:04]

rickyz@chromium.org changed reviewers:
+ nasko@chromium.org

[rickyz (no longer on Chrome), 2015-02-06 22:38:05]

Adding nasko@ for content/public/common/content_switches.h (sorry for spamming
you with so many of these lately)

(Sorry, accidentally included a rebase in that last upload.)

[nasko, 2015-02-06 22:39:09]

This is going to conflict with another CL of yours. LGTM

[rickyz (no longer on Chrome), 2015-02-06 22:40:21]

The CQ bit was checked by rickyz@chromium.org

[commit-bot: I haz the power, 2015-02-06 22:41:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/901683003/20001

[commit-bot: I haz the power, 2015-02-06 23:53:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-06 23:54:15]

Patchset 2 (id:??) landed as
https://crrev.com/8dea07ad5e83f5f4c11dfb3053d58016ccc000cf
Cr-Commit-Position: refs/heads/master@{#315139}