Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 901663005: Revert r189385 "Remove LifecycleContext" and r189391, r189530, r189456 that block it (Closed)

Created:
5 years, 10 months ago by pfeldman
Modified:
5 years, 10 months ago
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, rwlbuis, serviceworker-reviews, sof, tzik
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert r189385 "Remove LifecycleContext" Revert r189391 "Remove ExecutionContext::m_lifecycleNotifier" Revert r189530 "Allow creating new windows from a notificationclick event in SW." Revert r189456 "Remove unnecessary 'this->' from LifecycleNotifiers" TBR=haraken NOTRY=true NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -204 lines) Patch
M Source/bindings/core/v8/V8ScriptRunner.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/dom/ActiveDOMObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ActiveDOMObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContextLifecycleNotifier.h View 3 chunks +10 lines, -2 lines 0 comments Download
M Source/core/dom/ContextLifecycleNotifier.cpp View 4 chunks +7 lines, -3 lines 0 comments Download
M Source/core/dom/ContextLifecycleObserver.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/dom/ContextLifecycleObserver.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/dom/Document.h View 5 chunks +4 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 7 chunks +15 lines, -5 lines 0 comments Download
M Source/core/dom/DocumentLifecycleNotifier.h View 2 chunks +26 lines, -7 lines 0 comments Download
M Source/core/dom/DocumentLifecycleNotifier.cpp View 2 chunks +0 lines, -17 lines 0 comments Download
M Source/core/dom/DocumentLifecycleObserver.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentLifecycleObserver.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 6 chunks +17 lines, -12 lines 0 comments Download
M Source/core/dom/ExecutionContext.cpp View 7 chunks +36 lines, -16 lines 0 comments Download
M Source/core/dom/ScopedWindowFocusAllowedIndicator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/DOMWindowLifecycleNotifier.h View 2 chunks +6 lines, -7 lines 0 comments Download
M Source/core/frame/DOMWindowLifecycleNotifier.cpp View 2 chunks +8 lines, -5 lines 0 comments Download
M Source/core/frame/DOMWindowLifecycleObserver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/DOMWindowLifecycleObserver.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 5 chunks +8 lines, -2 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 7 chunks +17 lines, -8 lines 0 comments Download
M Source/core/page/Page.h View 4 chunks +7 lines, -2 lines 0 comments Download
M Source/core/page/Page.cpp View 6 chunks +15 lines, -5 lines 0 comments Download
M Source/core/page/PageLifecycleNotifier.h View 1 chunk +25 lines, -6 lines 0 comments Download
M Source/core/page/PageLifecycleNotifier.cpp View 2 chunks +0 lines, -16 lines 0 comments Download
M Source/core/page/PageLifecycleObserver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/PageLifecycleObserver.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.cpp View 3 chunks +7 lines, -18 lines 0 comments Download
A Source/platform/LifecycleContext.h View 1 chunk +104 lines, -0 lines 0 comments Download
M Source/platform/LifecycleContextTest.cpp View 3 chunks +15 lines, -11 lines 0 comments Download
M Source/platform/LifecycleNotifier.h View 4 chunks +8 lines, -4 lines 0 comments Download
M Source/platform/LifecycleObserver.h View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/WebScopedWindowFocusAllowedIndicatorTest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
pfeldman
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/23253/steps/telemetry_unittests%20%28with%20patch%29/logs/stdio suggests that r189385 is to blame. mlamouri@: your change will need to be re-applied
5 years, 10 months ago (2015-02-05 06:59:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901663005/1
5 years, 10 months ago (2015-02-05 07:01:16 UTC) #4
dcheng
lgtm
5 years, 10 months ago (2015-02-05 07:38:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901663005/1
5 years, 10 months ago (2015-02-05 07:39:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=189535
5 years, 10 months ago (2015-02-05 07:41:13 UTC) #9
haraken
On 2015/02/05 07:41:13, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
5 years, 10 months ago (2015-02-05 08:11:12 UTC) #10
haraken
Dcheng: As far as I see http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/23253/, it looks like a ton of tests are ...
5 years, 10 months ago (2015-02-05 08:22:48 UTC) #11
dcheng
I'm not sure. Unfortunately, I wasn't able to reproduce the failures at all today, which ...
5 years, 10 months ago (2015-02-05 08:29:24 UTC) #12
haraken
5 years, 10 months ago (2015-02-05 09:07:36 UTC) #14
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698