Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: Source/core/page/PageLifecycleNotifier.cpp

Issue 901663005: Revert r189385 "Remove LifecycleContext" and r189391, r189530, r189456 that block it (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/PageLifecycleNotifier.h ('k') | Source/core/page/PageLifecycleObserver.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All Rights Reserved. 2 * Copyright (C) 2013 Google Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 26
27 #include "config.h" 27 #include "config.h"
28 #include "core/page/PageLifecycleNotifier.h" 28 #include "core/page/PageLifecycleNotifier.h"
29 29
30 #include "core/page/PageLifecycleObserver.h"
31
32 namespace blink { 30 namespace blink {
33 31
34 PageLifecycleNotifier::PageLifecycleNotifier(Page* context) 32 PageLifecycleNotifier::PageLifecycleNotifier(Page* context)
35 : LifecycleNotifier<Page>(context) 33 : LifecycleNotifier<Page>(context)
36 { 34 {
37 } 35 }
38 36
39 void PageLifecycleNotifier::addObserver(PageLifecycleNotifier::Observer* observe r) 37 void PageLifecycleNotifier::addObserver(PageLifecycleNotifier::Observer* observe r)
40 { 38 {
41 if (observer->observerType() == Observer::PageLifecycleObserverType) { 39 if (observer->observerType() == Observer::PageLifecycleObserverType) {
42 RELEASE_ASSERT(m_iterating != IteratingOverPageObservers); 40 RELEASE_ASSERT(m_iterating != IteratingOverPageObservers);
43 m_pageObservers.add(static_cast<PageLifecycleObserver*>(observer)); 41 m_pageObservers.add(static_cast<PageLifecycleObserver*>(observer));
44 } 42 }
45 43
46 LifecycleNotifier<Page>::addObserver(observer); 44 LifecycleNotifier<Page>::addObserver(observer);
47 } 45 }
48 46
49 void PageLifecycleNotifier::removeObserver(PageLifecycleNotifier::Observer* obse rver) 47 void PageLifecycleNotifier::removeObserver(PageLifecycleNotifier::Observer* obse rver)
50 { 48 {
51 if (observer->observerType() == Observer::PageLifecycleObserverType) { 49 if (observer->observerType() == Observer::PageLifecycleObserverType) {
52 RELEASE_ASSERT(m_iterating != IteratingOverPageObservers); 50 RELEASE_ASSERT(m_iterating != IteratingOverPageObservers);
53 m_pageObservers.remove(static_cast<PageLifecycleObserver*>(observer)); 51 m_pageObservers.remove(static_cast<PageLifecycleObserver*>(observer));
54 } 52 }
55 53
56 LifecycleNotifier<Page>::removeObserver(observer); 54 LifecycleNotifier<Page>::removeObserver(observer);
57 } 55 }
58 56
59 void PageLifecycleNotifier::notifyPageVisibilityChanged()
60 {
61 TemporaryChange<IterationType> scope(m_iterating, IteratingOverPageObservers );
62 for (PageLifecycleObserver* pageObserver : m_pageObservers)
63 pageObserver->pageVisibilityChanged();
64 }
65
66 void PageLifecycleNotifier::notifyDidCommitLoad(LocalFrame* frame)
67 {
68 TemporaryChange<IterationType> scope(m_iterating, IteratingOverPageObservers );
69 for (PageLifecycleObserver* pageObserver : m_pageObservers)
70 pageObserver->didCommitLoad(frame);
71 }
72
73 } // namespace blink 57 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/page/PageLifecycleNotifier.h ('k') | Source/core/page/PageLifecycleObserver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698