Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 90153002: Call toWebCoreAtomicString() in V8Window::namedSecurityCheckCustom() (Closed)

Created:
7 years ago by Inactive
Modified:
7 years ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Call toWebCoreAtomicString() in V8Window::namedSecurityCheckCustom() Call toWebCoreAtomicString() in V8Window::namedSecurityCheckCustom() instead of toWebCoreString(). This avoids uselessly creating a String and then convert it to an AtomicString since FrameTree::scopedChild() takes an AtomicString in argument. R=haraken BUG=323739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162731

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/bindings/v8/custom/V8WindowCustom.cpp View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
https://codereview.chromium.org/90153002/diff/1/Source/bindings/v8/custom/V8WindowCustom.cpp File Source/bindings/v8/custom/V8WindowCustom.cpp (right): https://codereview.chromium.org/90153002/diff/1/Source/bindings/v8/custom/V8WindowCustom.cpp#newcode478 Source/bindings/v8/custom/V8WindowCustom.cpp:478: DEFINE_STATIC_LOCAL(const AtomicString, nameOfProtoProperty, ("__proto__", AtomicString::ConstructFromLiteral)); Not strictly related but ...
7 years ago (2013-11-27 01:11:41 UTC) #1
haraken
LGTM
7 years ago (2013-11-27 01:14:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/90153002/1
7 years ago (2013-11-27 01:17:20 UTC) #3
commit-bot: I haz the power
7 years ago (2013-11-27 02:59:37 UTC) #4
Message was sent while issue was closed.
Change committed as 162731

Powered by Google App Engine
This is Rietveld 408576698