Call toWebCoreAtomicString() in V8Window::namedSecurityCheckCustom()

Source/bindings/v8/custom/V8WindowCustom.cpp

 /*
  * Copyright (C) 2009, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 457 matching lines @@
 
     Frame* target = targetWindow->frame();
     if (!target)
         return false;
 
     // Notify the loader's client if the initial document has been accessed.
     if (target->loader().stateMachine()->isDisplayingInitialEmptyDocument())
         target->loader().didAccessInitialDocument();
 
     if (key->IsString()) {
-        DEFINE_STATIC_LOCAL(AtomicString, nameOfProtoProperty, ("__proto__", AtomicString::ConstructFromLiteral));
+        DEFINE_STATIC_LOCAL(const AtomicString, nameOfProtoProperty, ("__proto__", AtomicString::ConstructFromLiteral));

[Inactive, 2013/11/27 01:11:41]

Not strictly related but since I was editing this code...

 
-        String name = toWebCoreString(key.As<v8::String>());
+        AtomicString name = toWebCoreAtomicString(key.As<v8::String>());

[Inactive, 2013/11/27 01:11:41]

Note: This one is safe (cannot throw) as it takes a v8::String as argument. It
is the other one (taking a v8::Value in argument) that we want to get rid of.

         Frame* childFrame = target->tree().scopedChild(name);
         // Notice that we can't call HasRealNamedProperty for ACCESS_HAS
         // because that would generate infinite recursion.
         if (type == v8::ACCESS_HAS && childFrame)
             return true;
         // We need to explicitly compare against nameOfProtoProperty because
         // V8's JSObject::LocalLookup finds __proto__ before
         // interceptors and even when __proto__ isn't a "real named property".
         v8::Handle<v8::String> keyString = key.As<v8::String>();
         if (type == v8::ACCESS_GET
@@ skipping 70 matching lines @@
     v8::Handle<v8::Context> context = frame->script().currentWorldContext();
     if (context.IsEmpty())
         return v8Undefined();
 
     v8::Handle<v8::Object> global = context->Global();
     ASSERT(!global.IsEmpty());
     return global;
 }
 
 } // namespace WebCore