Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 901463002: De-client TestRequestTracker (Closed)

Created:
5 years, 10 months ago by jamesr
Modified:
5 years, 10 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

De-client TestRequestTracker This interface is used with to run the mojo_shell_tests which run a variety of services and send tracking information back and forth. The TestRequestTracker's Client was used for one back-and-forth that exchanged a string in one direction and a uint64 in the other. This inverts the direction in which the two are sent which cuts out an extra callback + message jump and renames TestRequestTrackerClientImpl to TrackedService to more closely match (I think) the intention. BUG=451319 R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/51b4cd64822b49971b9033220ef1062e45f08f53

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -159 lines) Patch
M services/test_service/BUILD.gn View 2 chunks +6 lines, -6 lines 0 comments Download
M services/test_service/test_request_tracker.mojom View 1 chunk +1 line, -8 lines 0 comments Download
M services/test_service/test_request_tracker_application.cc View 1 chunk +1 line, -3 lines 0 comments Download
D services/test_service/test_request_tracker_client_impl.h View 1 chunk +0 lines, -42 lines 0 comments Download
D services/test_service/test_request_tracker_client_impl.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M services/test_service/test_request_tracker_impl.h View 2 chunks +7 lines, -4 lines 0 comments Download
M services/test_service/test_request_tracker_impl.cc View 2 chunks +16 lines, -18 lines 1 comment Download
M services/test_service/test_service_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/test_service/test_service_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M services/test_service/test_time_service_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/test_service/test_time_service_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A + services/test_service/tracked_service.h View 3 chunks +10 lines, -14 lines 0 comments Download
A services/test_service/tracked_service.cc View 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
Git log (eventually) says you're responsible for this test.
5 years, 10 months ago (2015-02-03 22:14:33 UTC) #2
viettrungluu
I think Tim actually wrote nearly all of this, but rubberstamp lgtm (w/nit). https://codereview.chromium.org/901463002/diff/1/services/test_service/test_request_tracker_impl.cc File ...
5 years, 10 months ago (2015-02-04 00:27:35 UTC) #3
jamesr
5 years, 10 months ago (2015-02-04 19:27:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
51b4cd64822b49971b9033220ef1062e45f08f53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698