Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Unified Diff: services/test_service/tracked_service.h

Issue 901463002: De-client TestRequestTracker (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/test_service/tracked_service.h
diff --git a/services/test_service/test_request_tracker_client_impl.h b/services/test_service/tracked_service.h
similarity index 50%
rename from services/test_service/test_request_tracker_client_impl.h
rename to services/test_service/tracked_service.h
index cc341827080a018f2aa2266157d93a8ec99ea617..2470ffe849753c6847e514d9e30238fbaa447112 100644
--- a/services/test_service/test_request_tracker_client_impl.h
+++ b/services/test_service/tracked_service.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef SERVICES_TEST_SERVICE_TEST_REQUEST_TRACKER_CLIENT_IMPL_H_
-#define SERVICES_TEST_SERVICE_TEST_REQUEST_TRACKER_CLIENT_IMPL_H_
+#ifndef SERVICES_TEST_SERVICE_TRACKED_SERVICE_H_
+#define SERVICES_TEST_SERVICE_TRACKED_SERVICE_H_
#include "mojo/public/cpp/system/macros.h"
#include "services/test_service/test_request_tracker.mojom.h"
@@ -11,24 +11,20 @@
namespace mojo {
namespace test {
-class TestRequestTrackerClientImpl : public TestRequestTrackerClient {
+class TrackedService {
public:
- TestRequestTrackerClientImpl(
- TestRequestTrackerPtr tracker,
- const std::string& service_name,
- const mojo::Callback<void()>& tracking_connected_callback);
- ~TestRequestTrackerClientImpl() override;
+ TrackedService(TestRequestTrackerPtr tracker,
+ const std::string& service_name,
+ const mojo::Callback<void()>& tracking_connected_callback);
+ ~TrackedService();
// Call whenever an event happens that you want to be recorded.
void RecordNewRequest();
- // TestRequestTrackerClient impl.
- void SetIdAndReturnName(
- uint64_t id,
- const mojo::Callback<void(mojo::String)>& callback) override;
-
private:
+ void SetId(uint64_t id);
void SendStats();
+
uint64_t id_;
uint64_t requests_since_upload_;
const std::string service_name_;
@@ -39,4 +35,4 @@ class TestRequestTrackerClientImpl : public TestRequestTrackerClient {
} // namespace test
} // namespace mojo
-#endif // SERVICES_TEST_SERVICE_TEST_REQUEST_TRACKER_CLIENT_IMPL_H_
+#endif // SERVICES_TEST_SERVICE_TRACKED_SERVICE_H_

Powered by Google App Engine
This is Rietveld 408576698