Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1169)

Issue 9014010: Merge 100661 - CSS table with 100% width can overflow their containing block (Closed)

Created:
8 years, 11 months ago by Julien - ping for review
Modified:
8 years, 11 months ago
Reviewers:
jchaffraix
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/912/
Visibility:
Public.

Description

Merge 100661 - CSS table with 100% width can overflow their containing block https://bugs.webkit.org/show_bug.cgi?id=72180 Reviewed by David Hyatt. Source/WebCore: Tests: fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html fast/table/table-in-table-percent-width-collapsing-border.html fast/table/table-in-table-percent-width-quirks-mode.html fast/table/table-in-table-percent-width.html After r97555, we would include the borders in a CSS table's logical width even if the 'width' property was a percent. This does not match what Firefox and IE are doing. Thus don't apply this behavior to percent 'width'. * rendering/RenderTable.cpp: (WebCore::RenderTable::computeLogicalWidth): LayoutTests: Several tests to check that we don't overflow our containing block with width: 100%. * fast/table/table-in-table-percent-width-collapsing-border-expected.png: Added. * fast/table/table-in-table-percent-width-collapsing-border-expected.txt: Added. * fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.png: Added. * fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.txt: Added. * fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html: Added. * fast/table/table-in-table-percent-width-collapsing-border.html: Added. * fast/table/table-in-table-percent-width-expected.png: Added. * fast/table/table-in-table-percent-width-expected.txt: Added. * fast/table/table-in-table-percent-width-quirks-mode-expected.png: Added. * fast/table/table-in-table-percent-width-quirks-mode-expected.txt: Added. * fast/table/table-in-table-percent-width-quirks-mode.html: Added. * fast/table/table-in-table-percent-width.html: Added. TBR=jchaffraix@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-11 lines, --11 lines) Patch
A + LayoutTests/fast/table/table-in-table-percent-width.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/table-in-table-percent-width-collapsing-border.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/table-in-table-percent-width-collapsing-border-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/table-in-table-percent-width-collapsing-border-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/table-in-table-percent-width-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/table-in-table-percent-width-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/table-in-table-percent-width-quirks-mode.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/table-in-table-percent-width-quirks-mode-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/table-in-table-percent-width-quirks-mode-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderTable.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Julien - ping for review
8 years, 11 months ago (2012-01-03 10:01:29 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698