Let ninja/mac pass all gyp tests.

Let ninja/mac pass all gyp tests.

(Except for test/mac, which currently only runs with
xcode and make, and which doesn't work with ninja yet at all.)
Committed: http://code.google.com/p/gyp/source/detail?r=1112

[Nico, 2011-12-20 23:25:04]

This is a minimal-changes CL. I expect to revert the two changes made to the
generator fairly soon once the "real" code for this arrives, but since it's so
easy to get passing tests, I figured I'd start with that.

[tony, 2011-12-20 23:36:11]

http://codereview.chromium.org/9014002/diff/6001/test/lib/TestGyp.py
File test/lib/TestGyp.py (right):

http://codereview.chromium.org/9014002/diff/6001/test/lib/TestGyp.py#newcode456
test/lib/TestGyp.py:456: os.environ['DYLD_LIBRARY_PATH'] = libdir
Why is this different from the make/xcodebuild?

http://codereview.chromium.org/9014002/diff/6001/test/lib/TestGyp.py#newcode467
test/lib/TestGyp.py:467: if sys.platform != 'darwin':
Why is this different from the make/xcodebuild?

Nit: Merge the condition with 'and'?

[Nico, 2011-12-20 23:54:36]

http://codereview.chromium.org/9014002/diff/6001/test/lib/TestGyp.py
File test/lib/TestGyp.py (right):

http://codereview.chromium.org/9014002/diff/6001/test/lib/TestGyp.py#newcode456
test/lib/TestGyp.py:456: os.environ['DYLD_LIBRARY_PATH'] = libdir
On 2011/12/20 23:36:11, tony wrote:
> Why is this different from the make/xcodebuild?

The make build runs its compilations from the source root, and hence sets its
dylib search paths relative to the source root (they get written into
executables linked to the srcroot). Since tests are executed from the source
root, that works fine. The ninja build compilations from without out/Default but
runs tests from the source root, so libraries won't be found.

(eventually dylibs will go into out/Default instead of out/Default/lib to match
make and xcode, but this path still needs to be set. the xcode runner also sets
DYLD_LIBRARY_PATH to something, and with make it mostly works by accident.)

(In the real chromium build, we tell the linker which paths to embed into the
executable, so it's a test-only problem.)

http://codereview.chromium.org/9014002/diff/6001/test/lib/TestGyp.py#newcode467
test/lib/TestGyp.py:467: if sys.platform != 'darwin':
On 2011/12/20 23:36:11, tony wrote:
> Why is this different from the make/xcodebuild?

It's not, make and xcodebuild both put their static libraries right into
out/Default, like ninja/mac does now.

[tony, 2011-12-20 23:59:28]

Thanks for the explanations.  LGTM.