Let ninja/mac pass all gyp tests.

test/lib/TestGyp.py

 # Copyright (c) 2011 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 TestGyp.py:  a testing framework for GYP integration tests.
 """
 
 import os
 import re
@@ skipping 431 matching lines @@
     if target is None:
       target = 'all'
     arguments.append(target)
 
     kw['arguments'] = arguments
     return self.run(program=self.build_tool, **kw)
 
   def run_built_executable(self, name, *args, **kw):
     # Enclosing the name in a list avoids prepending the original dir.
     program = [self.built_file_path(name, type=self.EXECUTABLE, **kw)]
+    if sys.platform == 'darwin':
+      libdir = os.path.join('out', 'Default', 'lib')
+      if self.configuration:
+        libdir = os.path.join('out', self.configuration, 'lib')
+      os.environ['DYLD_LIBRARY_PATH'] = libdir

[tony, 2011/12/20 23:36:11]

Why is this different from the make/xcodebuild?

[Nico, 2011/12/20 23:54:38]

The make build runs its compilations from the source root, and hence sets its
dylib search paths relative to the source root (they get written into
executables linked to the srcroot). Since tests are executed from the source
root, that works fine. The ninja build compilations from without out/Default but
runs tests from the source root, so libraries won't be found.

(eventually dylibs will go into out/Default instead of out/Default/lib to match
make and xcode, but this path still needs to be set. the xcode runner also sets
DYLD_LIBRARY_PATH to something, and with make it mostly works by accident.)

(In the real chromium build, we tell the linker which paths to embed into the
executable, so it's a test-only problem.)

     return self.run(program=program, *args, **kw)
 
   def built_file_path(self, name, type=None, **kw):
     result = []
     chdir = kw.get('chdir')
     if chdir:
       result.append(chdir)
     result.append('out')
     result.append(self.configuration_dirname())
-    if type in (self.STATIC_LIB,):
-      result.append('obj')
-    elif type in (self.SHARED_LIB,):
+    if type == self.STATIC_LIB:
+      if sys.platform != 'darwin':

[tony, 2011/12/20 23:36:11]

Why is this different from the make/xcodebuild?

Nit: Merge the condition with 'and'?

[Nico, 2011/12/20 23:54:38]

It's not, make and xcodebuild both put their static libraries right into
out/Default, like ninja/mac does now.

+        result.append('obj')
+    elif type == self.SHARED_LIB:
       result.append('lib')
     subdir = kw.get('subdir')
     if subdir:
       result.append(subdir)
     result.append(self.built_file_basename(name, type, **kw))
     return self.workpath(*result)
 
   def up_to_date(self, gyp_file, target=None, **kw):
     kw['stdout'] = "ninja: no work to do.\n"
     return self.build(gyp_file, target, **kw)
@@ skipping 323 matching lines @@
   """
   format = kw.get('format')
   if format:
     del kw['format']
   else:
     format = os.environ.get('TESTGYP_FORMAT')
   for format_class in format_class_list:
     if format == format_class.format:
       return format_class(*args, **kw)
   raise Exception, "unknown format %r" % format