Add support in Telemetry for other Ozone based targets

Add support in Telemetry for other Ozone based targets

Prior to this commit, Telemetry on Linux Desktop was X11 oriented. The changes
introduced here allow other graphics architectures through Ozone as well for
testing, by recognizing a specific extra browser arguments "--ozone-platform".

For example one can use it as following:

./run_benchmark --browser=exact --browser-executable=./out/Release/chrome --extra-browser-args="--ozone-platform=gbm" <benchmark>

BUG=None

Committed: https://crrev.com/9468c5e022b7a53b7a09e4239d9cfd6537a9c5ac
Cr-Commit-Position: refs/heads/master@{#317671}

[vignatti (out of this project), 2015-02-09 22:16:17]

tiago.vignatti@intel.com changed reviewers:
+ nduca@chromium.org

[vignatti (out of this project), 2015-02-09 22:20:27]

tiago.vignatti@intel.com changed reviewers:
+ dnicoara@chromium.org

[vignatti (out of this project), 2015-02-09 22:21:02]

Hey Nat and Daniel. Just trying out GBM builds here in Telemetry... wdyt?

[dnicoara, 2015-02-10 17:29:04]

https://codereview.chromium.org/901143006/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py
(right):

https://codereview.chromium.org/901143006/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py:264: if
"--ozone-platform=gbm" in i:
Could we just check that the --ozone-platform flag is passed, without a
platform? I'm thinking that other Ozone platforms may benefit from this as well.

[vignatti (out of this project), 2015-02-10 19:39:57]

PTAL dnicoara@

https://codereview.chromium.org/901143006/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py
(right):

https://codereview.chromium.org/901143006/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py:264: if
"--ozone-platform=gbm" in i:
On 2015/02/10 17:29:03, dnicoara wrote:
> Could we just check that the --ozone-platform flag is passed, without a
> platform? I'm thinking that other Ozone platforms may benefit from this as
well.

Done.

[dnicoara, 2015-02-10 19:44:35]

Thanks, lgtm with nits.

https://codereview.chromium.org/901143006/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py
(right):

https://codereview.chromium.org/901143006/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py:262:
has_ozone_display = False
nit: Name this 'has_ozone_platform' since there aren't any checks for a platform
display.

https://codereview.chromium.org/901143006/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py:263:
for i in finder_options.browser_options.extra_browser_args:
nit: Maybe use 'arg' instead of 'i' for better context?

[vignatti (out of this project), 2015-02-10 19:49:06]

New patchsets have been uploaded after l-g-t-m from dnicoara@chromium.org

[vignatti (out of this project), 2015-02-10 19:50:19]

nduca@ PTAL.

https://codereview.chromium.org/901143006/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py
(right):

https://codereview.chromium.org/901143006/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py:262:
has_ozone_display = False
On 2015/02/10 19:44:35, dnicoara wrote:
> nit: Name this 'has_ozone_platform' since there aren't any checks for a
platform
> display.

Done.

https://codereview.chromium.org/901143006/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py:263:
for i in finder_options.browser_options.extra_browser_args:
On 2015/02/10 19:44:35, dnicoara wrote:
> nit: Maybe use 'arg' instead of 'i' for better context?

Done.

[nduca, 2015-02-11 23:13:29]

i cant review this, please consult telemetry@chromium.org for reviewers or the
OWNERS file

[sullivan, 2015-02-12 15:34:33]

sullivan@chromium.org changed reviewers:
+ dtu@chromium.org, sullivan@chromium.org

[sullivan, 2015-02-12 15:34:34]

+dtu since this has a command line args change

[vignatti (out of this project), 2015-02-19 19:41:00]

dtu@ PTAL.

[vignatti (out of this project), 2015-02-19 19:41:31]

tiago.vignatti@intel.com changed required reviewers:
+ dtu@chromium.org

[vignatti (out of this project), 2015-02-23 18:47:44]

tiago.vignatti@intel.com changed reviewers:
+ tonyg@chromium.org

[vignatti (out of this project), 2015-02-23 18:47:55]

+tonyg, please take a look as a telemetry owner.

[dtu, 2015-02-23 19:18:08]

lgtm

[vignatti (out of this project), 2015-02-23 19:27:43]

The CQ bit was checked by tiago.vignatti@intel.com

[commit-bot: I haz the power, 2015-02-23 19:28:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/901143006/40001

[commit-bot: I haz the power, 2015-02-23 19:36:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 19:36:13]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[vignatti (out of this project), 2015-02-23 21:28:32]

The CQ bit was checked by tiago.vignatti@intel.com

[commit-bot: I haz the power, 2015-02-23 21:28:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/901143006/40001

[commit-bot: I haz the power, 2015-02-23 23:00:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-23 23:01:16]

Patchset 3 (id:??) landed as
https://crrev.com/9468c5e022b7a53b7a09e4239d9cfd6537a9c5ac
Cr-Commit-Position: refs/heads/master@{#317671}