Source/core/animation/AnimatableLength.h - Issue 90113003: Web Animations CSS: Fix crash when animating viewport units

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/AnimatableLength.h

Issue 90113003: Web Animations CSS: Fix crash when animating viewport units (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Preserve legacy viewport unit blend behaviour Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/animations/interpolation/line-height-interpolation.html ('K') | « LayoutTests/virtual/legacy-animations-engine/animations/interpolation/line-height-interpolation-expected.txt ('k') | Source/core/animation/AnimatableLength.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/AnimatableLength.h

diff --git a/Source/core/animation/AnimatableLength.h b/Source/core/animation/AnimatableLength.h

index 167ff848bf0867a162c93e6f417ce3ccc964c261..7017ac723eef463f678b1aa1ea76ac28e13fc781 100644

--- a/Source/core/animation/AnimatableLength.h

+++ b/Source/core/animation/AnimatableLength.h

@@ -102,6 +102,11 @@ private:

return m_unitType == UnitTypeCalc;

}

+ bool isViewportUnit() const

+ {

+ return m_unitType == UnitTypeViewportWidth || m_unitType == UnitTypeViewportHeight || m_unitType == UnitTypeViewportMin || m_unitType == UnitTypeViewportMax;

+ }

static PassRefPtr<AnimatableLength> create(const AnimatableLength* leftAddend, const AnimatableLength* rightAddend)

{

ASSERT(leftAddend && rightAddend);