Web Animations CSS: Fix crash when animating viewport units

Web Animations CSS: Fix crash when animating viewport units

This patch makes viewport units default to snapping behaviour when
mismatched instead of animating them smoothly, this matches legacy
animation behaviour.

BUG=322675
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162956

[dstockwell, 2013-11-27 01:18:15]

https://codereview.chromium.org/90113003/diff/1/LayoutTests/animations/viewpo...
File LayoutTests/animations/viewport-unit-crash.html (right):

https://codereview.chromium.org/90113003/diff/1/LayoutTests/animations/viewpo...
LayoutTests/animations/viewport-unit-crash.html:3: from { line-height: 25vw; }
Can we add cases that cover this to one of the interpolation/ tests?

[dstockwell, 2013-11-27 03:21:14]

> work is currently underway to make this happen

Is there a bug for this?

[Timothy Loh, 2013-11-27 04:29:36]

On 2013/11/27 03:21:14, dstockwell wrote:
> > work is currently underway to make this happen
> 
> Is there a bug for this?

I'm tracking related clean-ups on crbug.com/322365. Viewport units being
resolved at style time will be marked against crbug.com/124331 and viewport
units working with calc against crbug.com/168840.

[alancutter (OOO until 2018), 2013-11-27 04:55:24]

Added viewport unit bug to description.

https://codereview.chromium.org/90113003/diff/1/LayoutTests/animations/viewpo...
File LayoutTests/animations/viewport-unit-crash.html (right):

https://codereview.chromium.org/90113003/diff/1/LayoutTests/animations/viewpo...
LayoutTests/animations/viewport-unit-crash.html:3: from { line-height: 25vw; }
On 2013/11/27 01:18:15, dstockwell wrote:
> Can we add cases that cover this to one of the interpolation/ tests?

Done.

[dstockwell, 2013-11-27 05:05:35]

On 2013/11/27 04:55:24, alancutter wrote:
> Added viewport unit bug to description.
> 
>
https://codereview.chromium.org/90113003/diff/1/LayoutTests/animations/viewpo...
> File LayoutTests/animations/viewport-unit-crash.html (right):
> 
>
https://codereview.chromium.org/90113003/diff/1/LayoutTests/animations/viewpo...
> LayoutTests/animations/viewport-unit-crash.html:3: from { line-height: 25vw; }
> On 2013/11/27 01:18:15, dstockwell wrote:
> > Can we add cases that cover this to one of the interpolation/ tests?
> 
> Done.

Looks like viewport units can be animated in the legacy system?
http://jsfiddle.net/S8vvU/

[alancutter (OOO until 2018), 2013-11-27 06:05:04]

On 2013/11/27 05:05:35, dstockwell wrote:
> On 2013/11/27 04:55:24, alancutter wrote:
> > Added viewport unit bug to description.
> > 
> >
>
https://codereview.chromium.org/90113003/diff/1/LayoutTests/animations/viewpo...
> > File LayoutTests/animations/viewport-unit-crash.html (right):
> > 
> >
>
https://codereview.chromium.org/90113003/diff/1/LayoutTests/animations/viewpo...
> > LayoutTests/animations/viewport-unit-crash.html:3: from { line-height: 25vw;
}
> > On 2013/11/27 01:18:15, dstockwell wrote:
> > > Can we add cases that cover this to one of the interpolation/ tests?
> > 
> > Done.
> 
> Looks like viewport units can be animated in the legacy system?
> http://jsfiddle.net/S8vvU/

You're quite right.
Added blending between same viewport units back.

[dstockwell, 2013-11-27 09:27:34]

https://codereview.chromium.org/90113003/diff/40001/LayoutTests/animations/in...
File LayoutTests/animations/interpolation/line-height-interpolation.html
(right):

https://codereview.chromium.org/90113003/diff/40001/LayoutTests/animations/in...
LayoutTests/animations/interpolation/line-height-interpolation.html:161: {at:
-0.25, is: '100px'},
This seems to suggest that stepping is the correct behavior? The values here
should represent what would be output if interpolation was correctly implemented
and the expectation should contain FAIL lines for now.

[alancutter (OOO until 2018), 2013-11-27 23:31:51]

https://codereview.chromium.org/90113003/diff/40001/LayoutTests/animations/in...
File LayoutTests/animations/interpolation/line-height-interpolation.html
(right):

https://codereview.chromium.org/90113003/diff/40001/LayoutTests/animations/in...
LayoutTests/animations/interpolation/line-height-interpolation.html:161: {at:
-0.25, is: '100px'},
On 2013/11/27 09:27:34, dstockwell wrote:
> This seems to suggest that stepping is the correct behavior? The values here
> should represent what would be output if interpolation was correctly
implemented
> and the expectation should contain FAIL lines for now.

Done.

[alancutter (OOO until 2018), 2013-11-28 22:29:53]

dstockwell: Poke.

[dstockwell, 2013-11-28 22:52:32]

lgtm

[commit-bot: I haz the power, 2013-11-28 22:52:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/90113003/60001

[commit-bot: I haz the power, 2013-11-29 08:13:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/90113003/60001

[commit-bot: I haz the power, 2013-11-29 10:58:15]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[alancutter1, 2013-11-29 12:25:36]

On 2013/11/29 10:58:15, I haz the power (commit-bot) wrote:
> Retried try job too often on win_blink_rel for step(s) webkit_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

-FAIL: line-height from [14px] to [normal] was [24.19999885559082px] at -0.3,
expected [14px]
+FAIL: line-height from [14px] to [normal] was [24.200000762939453px] at -0.3,
expected [14px]

D:

[dstockwell, 2013-11-29 22:59:01]

On 2013/11/29 12:25:36, Do not use (alancutter) wrote:
> On 2013/11/29 10:58:15, I haz the power (commit-bot) wrote:
> > Retried try job too often on win_blink_rel for step(s) webkit_tests
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...
> 
> -FAIL: line-height from [14px] to [normal] was [24.19999885559082px] at -0.3,
> expected [14px]
> +FAIL: line-height from [14px] to [normal] was [24.200000762939453px] at -0.3,
> expected [14px]
> 
> D:

This test previously had platform specific expectations. Need to add them back.

[commit-bot: I haz the power, 2013-12-01 23:55:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/90113003/70001

[commit-bot: I haz the power, 2013-12-02 01:16:55]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-12-02 04:24:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/90113003/90001

[commit-bot: I haz the power, 2013-12-02 05:28:15]

Change committed as 162956