Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 900893003: Revert "Disable PopupBlockerBrowserTest.CtrlEnterKey" (Closed)

Created:
5 years, 10 months ago by Miyoung Shin
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Disable PopupBlockerBrowserTest.CtrlEnterKey" We can rever it due to fixed Ctrl-Enter Key issue. > Disable PopupBlockerBrowserTest.CtrlEnterKey > > Failing due to Blink r189541 which can't just be reverted. Disable this > test while investigating the Blink r198541 failure. Landing to progress > the Blink roll. > > TBR=jochen@chromum.org > NOTREECHECK=true > NOTRY=true > BUG=455691 BUG=455691 R=jochen@chromum.org Committed: https://crrev.com/181fd72851b24e9dd6005dd1784b95792d3e514f Cr-Commit-Position: refs/heads/master@{#315758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Miyoung Shin
jochen@, We can revert this after landing https://crrev.com/910693004/ that need your review.
5 years, 10 months ago (2015-02-09 11:58:45 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-10 10:37:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900893003/1
5 years, 10 months ago (2015-02-11 14:18:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 14:47:35 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 14:48:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/181fd72851b24e9dd6005dd1784b95792d3e514f
Cr-Commit-Position: refs/heads/master@{#315758}

Powered by Google App Engine
This is Rietveld 408576698